Do not use java.nio in crashtracking init (premain)#11080
Do not use java.nio in crashtracking init (premain)#11080gh-worker-dd-mergequeue-cf854d[bot] merged 6 commits into
Conversation
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 62 metrics, 9 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.62.0-SNAPSHOT~70c5d4c69c, baseline=1.62.0-SNAPSHOT~995f760c78
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.059 s) : 0, 1058899
Total [baseline] (11.132 s) : 0, 11132261
Agent [candidate] (1.058 s) : 0, 1058413
Total [candidate] (11.031 s) : 0, 11031315
section appsec
Agent [baseline] (1.26 s) : 0, 1259916
Total [baseline] (11.018 s) : 0, 11018381
Agent [candidate] (1.264 s) : 0, 1264204
Total [candidate] (10.958 s) : 0, 10958278
section iast
Agent [baseline] (1.241 s) : 0, 1241411
Total [baseline] (11.394 s) : 0, 11394173
Agent [candidate] (1.235 s) : 0, 1234582
Total [candidate] (11.353 s) : 0, 11353029
section profiling
Agent [baseline] (1.199 s) : 0, 1199148
Total [baseline] (11.043 s) : 0, 11042891
Agent [candidate] (1.188 s) : 0, 1188057
Total [candidate] (11.043 s) : 0, 11043482
gantt
title petclinic - break down per module: candidate=1.62.0-SNAPSHOT~70c5d4c69c, baseline=1.62.0-SNAPSHOT~995f760c78
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.228 ms) : 0, 1228
crashtracking [candidate] (1.227 ms) : 0, 1227
BytebuddyAgent [baseline] (633.223 ms) : 0, 633223
BytebuddyAgent [candidate] (633.514 ms) : 0, 633514
AgentMeter [baseline] (29.576 ms) : 0, 29576
AgentMeter [candidate] (29.511 ms) : 0, 29511
GlobalTracer [baseline] (249.453 ms) : 0, 249453
GlobalTracer [candidate] (249.559 ms) : 0, 249559
AppSec [baseline] (32.511 ms) : 0, 32511
AppSec [candidate] (32.36 ms) : 0, 32360
Debugger [baseline] (59.791 ms) : 0, 59791
Debugger [candidate] (59.839 ms) : 0, 59839
Remote Config [baseline] (596.485 µs) : 0, 596
Remote Config [candidate] (589.396 µs) : 0, 589
Telemetry [baseline] (8.008 ms) : 0, 8008
Telemetry [candidate] (8.054 ms) : 0, 8054
Flare Poller [baseline] (8.365 ms) : 0, 8365
Flare Poller [candidate] (7.636 ms) : 0, 7636
section appsec
crashtracking [baseline] (1.232 ms) : 0, 1232
crashtracking [candidate] (1.228 ms) : 0, 1228
BytebuddyAgent [baseline] (673.082 ms) : 0, 673082
BytebuddyAgent [candidate] (676.724 ms) : 0, 676724
AgentMeter [baseline] (12.167 ms) : 0, 12167
AgentMeter [candidate] (12.19 ms) : 0, 12190
GlobalTracer [baseline] (248.754 ms) : 0, 248754
GlobalTracer [candidate] (249.648 ms) : 0, 249648
AppSec [baseline] (186.089 ms) : 0, 186089
AppSec [candidate] (187.862 ms) : 0, 187862
Debugger [baseline] (66.003 ms) : 0, 66003
Debugger [candidate] (63.932 ms) : 0, 63932
Remote Config [baseline] (582.436 µs) : 0, 582
Remote Config [candidate] (567.664 µs) : 0, 568
Telemetry [baseline] (7.929 ms) : 0, 7929
Telemetry [candidate] (7.871 ms) : 0, 7871
Flare Poller [baseline] (3.506 ms) : 0, 3506
Flare Poller [candidate] (3.422 ms) : 0, 3422
IAST [baseline] (24.231 ms) : 0, 24231
IAST [candidate] (24.323 ms) : 0, 24323
section iast
crashtracking [baseline] (1.256 ms) : 0, 1256
crashtracking [candidate] (1.215 ms) : 0, 1215
BytebuddyAgent [baseline] (816.285 ms) : 0, 816285
BytebuddyAgent [candidate] (809.355 ms) : 0, 809355
AgentMeter [baseline] (11.554 ms) : 0, 11554
AgentMeter [candidate] (11.503 ms) : 0, 11503
GlobalTracer [baseline] (240.642 ms) : 0, 240642
GlobalTracer [candidate] (240.916 ms) : 0, 240916
AppSec [baseline] (29.602 ms) : 0, 29602
AppSec [candidate] (29.679 ms) : 0, 29679
Debugger [baseline] (63.845 ms) : 0, 63845
Debugger [candidate] (64.939 ms) : 0, 64939
Remote Config [baseline] (528.701 µs) : 0, 529
Remote Config [candidate] (527.765 µs) : 0, 528
Telemetry [baseline] (7.785 ms) : 0, 7785
Telemetry [candidate] (7.751 ms) : 0, 7751
Flare Poller [baseline] (3.384 ms) : 0, 3384
Flare Poller [candidate] (3.46 ms) : 0, 3460
IAST [baseline] (30.289 ms) : 0, 30289
IAST [candidate] (29.163 ms) : 0, 29163
section profiling
crashtracking [baseline] (1.203 ms) : 0, 1203
crashtracking [candidate] (1.181 ms) : 0, 1181
BytebuddyAgent [baseline] (700.579 ms) : 0, 700579
BytebuddyAgent [candidate] (693.011 ms) : 0, 693011
AgentMeter [baseline] (9.328 ms) : 0, 9328
AgentMeter [candidate] (9.063 ms) : 0, 9063
GlobalTracer [baseline] (209.621 ms) : 0, 209621
GlobalTracer [candidate] (208.82 ms) : 0, 208820
AppSec [baseline] (33.262 ms) : 0, 33262
AppSec [candidate] (32.653 ms) : 0, 32653
Debugger [baseline] (66.259 ms) : 0, 66259
Debugger [candidate] (65.931 ms) : 0, 65931
Remote Config [baseline] (594.081 µs) : 0, 594
Remote Config [candidate] (574.057 µs) : 0, 574
Telemetry [baseline] (7.892 ms) : 0, 7892
Telemetry [candidate] (7.867 ms) : 0, 7867
Flare Poller [baseline] (3.583 ms) : 0, 3583
Flare Poller [candidate] (3.509 ms) : 0, 3509
ProfilingAgent [baseline] (94.992 ms) : 0, 94992
ProfilingAgent [candidate] (94.043 ms) : 0, 94043
Profiling [baseline] (95.554 ms) : 0, 95554
Profiling [candidate] (94.611 ms) : 0, 94611
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.62.0-SNAPSHOT~70c5d4c69c, baseline=1.62.0-SNAPSHOT~995f760c78
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1064038
Total [baseline] (8.874 s) : 0, 8874169
Agent [candidate] (1.065 s) : 0, 1064520
Total [candidate] (8.829 s) : 0, 8829291
section iast
Agent [baseline] (1.229 s) : 0, 1229449
Total [baseline] (9.553 s) : 0, 9552744
Agent [candidate] (1.234 s) : 0, 1233613
Total [candidate] (9.552 s) : 0, 9551796
gantt
title insecure-bank - break down per module: candidate=1.62.0-SNAPSHOT~70c5d4c69c, baseline=1.62.0-SNAPSHOT~995f760c78
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.241 ms) : 0, 1241
crashtracking [candidate] (1.237 ms) : 0, 1237
BytebuddyAgent [baseline] (637.335 ms) : 0, 637335
BytebuddyAgent [candidate] (636.992 ms) : 0, 636992
AgentMeter [baseline] (29.814 ms) : 0, 29814
AgentMeter [candidate] (29.696 ms) : 0, 29696
GlobalTracer [baseline] (250.134 ms) : 0, 250134
GlobalTracer [candidate] (250.482 ms) : 0, 250482
AppSec [baseline] (32.703 ms) : 0, 32703
AppSec [candidate] (32.647 ms) : 0, 32647
Debugger [baseline] (59.5 ms) : 0, 59500
Debugger [candidate] (59.508 ms) : 0, 59508
Remote Config [baseline] (604.657 µs) : 0, 605
Remote Config [candidate] (595.916 µs) : 0, 596
Telemetry [baseline] (8.082 ms) : 0, 8082
Telemetry [candidate] (8.081 ms) : 0, 8081
Flare Poller [baseline] (8.29 ms) : 0, 8290
Flare Poller [candidate] (9.007 ms) : 0, 9007
section iast
crashtracking [baseline] (1.239 ms) : 0, 1239
crashtracking [candidate] (1.242 ms) : 0, 1242
BytebuddyAgent [baseline] (807.622 ms) : 0, 807622
BytebuddyAgent [candidate] (811.616 ms) : 0, 811616
AgentMeter [baseline] (11.379 ms) : 0, 11379
AgentMeter [candidate] (11.459 ms) : 0, 11459
GlobalTracer [baseline] (239.097 ms) : 0, 239097
GlobalTracer [candidate] (239.331 ms) : 0, 239331
AppSec [baseline] (27.6 ms) : 0, 27600
AppSec [candidate] (26.545 ms) : 0, 26545
Debugger [baseline] (63.954 ms) : 0, 63954
Debugger [candidate] (64.779 ms) : 0, 64779
Remote Config [baseline] (536.245 µs) : 0, 536
Remote Config [candidate] (526.225 µs) : 0, 526
Telemetry [baseline] (7.672 ms) : 0, 7672
Telemetry [candidate] (7.749 ms) : 0, 7749
Flare Poller [baseline] (3.357 ms) : 0, 3357
Flare Poller [candidate] (3.442 ms) : 0, 3442
IAST [baseline] (30.966 ms) : 0, 30966
IAST [candidate] (29.972 ms) : 0, 29972
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 5 performance regressions! Performance is the same for 15 metrics, 16 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~70c5d4c69c, baseline=1.62.0-SNAPSHOT~995f760c78
dateFormat X
axisFormat %s
section baseline
no_agent (1.245 ms) : 1233, 1257
. : milestone, 1245,
iast (3.228 ms) : 3180, 3275
. : milestone, 3228,
iast_FULL (5.791 ms) : 5733, 5849
. : milestone, 5791,
iast_GLOBAL (3.833 ms) : 3765, 3900
. : milestone, 3833,
profiling (2.225 ms) : 2204, 2246
. : milestone, 2225,
tracing (1.863 ms) : 1847, 1879
. : milestone, 1863,
section candidate
no_agent (1.237 ms) : 1226, 1249
. : milestone, 1237,
iast (3.419 ms) : 3367, 3472
. : milestone, 3419,
iast_FULL (6.157 ms) : 6093, 6222
. : milestone, 6157,
iast_GLOBAL (3.72 ms) : 3652, 3788
. : milestone, 3720,
profiling (2.55 ms) : 2524, 2576
. : milestone, 2550,
tracing (1.937 ms) : 1920, 1953
. : milestone, 1937,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.62.0-SNAPSHOT~70c5d4c69c, baseline=1.62.0-SNAPSHOT~995f760c78
dateFormat X
axisFormat %s
section baseline
no_agent (18.335 ms) : 18151, 18518
. : milestone, 18335,
appsec (18.93 ms) : 18742, 19118
. : milestone, 18930,
code_origins (17.953 ms) : 17776, 18130
. : milestone, 17953,
iast (18.139 ms) : 17960, 18318
. : milestone, 18139,
profiling (18.74 ms) : 18554, 18927
. : milestone, 18740,
tracing (17.731 ms) : 17558, 17904
. : milestone, 17731,
section candidate
no_agent (19.46 ms) : 19261, 19659
. : milestone, 19460,
appsec (18.757 ms) : 18566, 18949
. : milestone, 18757,
code_origins (18.097 ms) : 17913, 18280
. : milestone, 18097,
iast (17.969 ms) : 17791, 18148
. : milestone, 17969,
profiling (18.629 ms) : 18442, 18816
. : milestone, 18629,
tracing (18.103 ms) : 17924, 18283
. : milestone, 18103,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~70c5d4c69c, baseline=1.62.0-SNAPSHOT~995f760c78
dateFormat X
axisFormat %s
section baseline
no_agent (1.483 ms) : 1472, 1495
. : milestone, 1483,
appsec (3.751 ms) : 3535, 3968
. : milestone, 3751,
iast (2.272 ms) : 2202, 2342
. : milestone, 2272,
iast_GLOBAL (2.314 ms) : 2244, 2383
. : milestone, 2314,
profiling (2.102 ms) : 2047, 2157
. : milestone, 2102,
tracing (2.091 ms) : 2037, 2145
. : milestone, 2091,
section candidate
no_agent (1.485 ms) : 1473, 1497
. : milestone, 1485,
appsec (3.816 ms) : 3593, 4039
. : milestone, 3816,
iast (2.271 ms) : 2202, 2341
. : milestone, 2271,
iast_GLOBAL (2.319 ms) : 2249, 2389
. : milestone, 2319,
profiling (2.091 ms) : 2036, 2145
. : milestone, 2091,
tracing (2.073 ms) : 2020, 2127
. : milestone, 2073,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.62.0-SNAPSHOT~70c5d4c69c, baseline=1.62.0-SNAPSHOT~995f760c78
dateFormat X
axisFormat %s
section baseline
no_agent (15.648 s) : 15648000, 15648000
. : milestone, 15648000,
appsec (14.684 s) : 14684000, 14684000
. : milestone, 14684000,
iast (18.738 s) : 18738000, 18738000
. : milestone, 18738000,
iast_GLOBAL (18.015 s) : 18015000, 18015000
. : milestone, 18015000,
profiling (14.733 s) : 14733000, 14733000
. : milestone, 14733000,
tracing (14.736 s) : 14736000, 14736000
. : milestone, 14736000,
section candidate
no_agent (15.403 s) : 15403000, 15403000
. : milestone, 15403000,
appsec (14.737 s) : 14737000, 14737000
. : milestone, 14737000,
iast (18.782 s) : 18782000, 18782000
. : milestone, 18782000,
iast_GLOBAL (17.974 s) : 17974000, 17974000
. : milestone, 17974000,
profiling (15.108 s) : 15108000, 15108000
. : milestone, 15108000,
tracing (15.029 s) : 15029000, 15029000
. : milestone, 15029000,
|
aba8a0e to
a539994
Compare
…racking/CrashUploaderScriptInitializer.java Co-authored-by: Jaroslav Bachorik <[email protected]>
…racking/ConfigManager.java Co-authored-by: Jaroslav Bachorik <[email protected]>
…racking/CrashUploaderScriptInitializer.java Co-authored-by: Stuart McCulloch <[email protected]>
4ec38d2 to
70c5d4c
Compare
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
What Does This Do
Avoid using
java.nioin the initialisation part of the crashtracking agent. This because, at this point, initializing java.nio can lead to side effects (deadlocks, premature initialisations, etc..)Also, the same operations can be done using a regular java.io
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.