Skip to content

Add the class "dataframe"#128

Merged
flying-sheep merged 4 commits into
IRkernel:masterfrom
ramnathv:master
Jun 11, 2020
Merged

Add the class "dataframe"#128
flying-sheep merged 4 commits into
IRkernel:masterfrom
ramnathv:master

Conversation

@ramnathv
Copy link
Copy Markdown
Contributor

This will pretty-print the tables as a nice table with striped rows.

This will pretty-print the tables as a nice table with striped rows.
@flying-sheep
Copy link
Copy Markdown
Member

ah cool, where? jupyter lab? notebook? vs code?

@ramnathv
Copy link
Copy Markdown
Contributor Author

@flying-sheep Sorry, I realized much later that this class is required on Google Colab for pretty-printing R data frames just like pandas data frames. For regular Jupyter Notebooks, the display is already nice!

@flying-sheep
Copy link
Copy Markdown
Member

OK! Just fix the tests and I’ll merge it

@ramnathv
Copy link
Copy Markdown
Contributor Author

@flying-sheep I don't see any tests that are failing. the CI logs seem to indicate that the raster package is missing.

@flying-sheep
Copy link
Copy Markdown
Member

In oldrel, yes, seems like that one’s broken or flaky. But in the release job, you can see test failures: https://travis-ci.org/github/IRkernel/repr/jobs/675920799

@ramnathv
Copy link
Copy Markdown
Contributor Author

I fixed the tests. It passes on oldrel, but the CI seems broken for release and devel, unrelated to the tests. https://travis-ci.org/github/IRkernel/repr/builds/696960507

@flying-sheep flying-sheep merged commit e82a319 into IRkernel:master Jun 11, 2020
@flying-sheep
Copy link
Copy Markdown
Member

Seems like it, weird. Thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants