Fix for dev stringr#157
Conversation
Where `str_view()` now prefers a console display that uses cli for colouring
|
Doesn’t work with the current version: So either repr has to wait for the new stringr to get released (which would result in temporary breakage) or we make the code forward compatible without breaking compatibility with the current version. You could just do a patch release 1.4.2 for stringr that accepts |
|
Sorry, the stringr dev version is so old, I'd forgotten that this argument wasn't in the CRAN version. Given that this is in a test, and I presume you're just using |
|
Ah right, didn’t notice this was just tests! Sure, I’ll merge this once the new version is out, if that happens soon enough that I remember why I subscribed to tidyverse/stringr releases. Thank you for helping out with the reverse deps! |
* Conditionally use html = TRUE if needed * Move skip_if_installed() checks
|
This patch should work regardless of the version of stringr, so you can merge/release whenever. I haven't official kicked off the stringr release process, but I'll ping this PR when I do (unless it's obvious that an updated repr is already on CRAN). |
|
FYI stringr is now scheduled for release to CRAN on Dec 2. |
|
thank you for the info! |
Where
str_view()now prefers a console display that uses cli for colouring