Skip to content

[TRTLLM-10804][infra] add ubuntu2404 wheel image for SBSA#12436

Merged
niukuo merged 1 commit into
NVIDIA:mainfrom
niukuo:dlfw_docker
Mar 31, 2026
Merged

[TRTLLM-10804][infra] add ubuntu2404 wheel image for SBSA#12436
niukuo merged 1 commit into
NVIDIA:mainfrom
niukuo:dlfw_docker

Conversation

@niukuo
Copy link
Copy Markdown
Collaborator

@niukuo niukuo commented Mar 23, 2026 •
edited
Loading

Summary by CodeRabbit

  • New Features

    • Added Ubuntu 24.04 Docker image support alongside existing Ubuntu 22.04 for CUDA development environments
    • Introduced new CI build configuration for Ubuntu 24.04 with Python 3.12.3

  • Chores

    • Enhanced Docker build toolchain with additional development dependencies
    • Improved Python package initialization and system compatibility configuration

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

@niukuo niukuo requested review from a team as code owners March 23, 2026 03:05
@niukuo niukuo requested review from mzweilz and tburt-nv March 23, 2026 03:05
@niukuo
Copy link
Copy Markdown
Collaborator Author

niukuo commented Mar 23, 2026

/bot run --stage-list "Build-Docker-Images"

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 23, 2026 •
edited
Loading

📝 Walkthrough

Walkthrough

The PR extends Docker build infrastructure to support Ubuntu 24.04 with CUDA 13.1.0, adding a new make target and CI pipeline configuration. It refines base package dependencies by including autoconf/libtool/automake and configuring pip system package policies, while removing specific packages from TensorRT/Triton installation flows and cleaning up conflicting CUDA apt sources.

Changes

Cohort / File(s) Summary
Docker Build Targets
docker/Makefile		 Added new ubuntu24_% make target with BASE_TAG = 13.1.0-devel-ubuntu24.04. Updated comments to clarify ubuntu22 vs ubuntu24 platform coverage without altering shared build logic.
Base Package Dependencies
docker/common/install_base.sh		 Expanded apt install set to include libtool, autoconf, automake. Added pip configuration to allow system package breaking and bootstrapping pip toolchain with pip3 install --ignore-installed pip setuptools wheel.
Installation Cleanup
docker/common/install_tensorrt.sh, docker/common/install_triton.sh		 Removed /etc/apt/sources.list.d/cuda.list after NVIDIA CUDA keyring download. Removed python3-build package from Triton Ubuntu apt dependency list.
CI Pipeline Configuration
jenkins/BuildDockerImage.groovy		 Added pattern matching for ^ubuntu\d+$ targets to derive BASE_IMAGE from Makefile. Extended CI build matrix with new configuration for Ubuntu 24.04 ARM64 Python 3.12 builds (target: "ubuntu24", arch: "arm64", PYTHON_VERSION=3.12.3).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ⚠️ Warning The PR description is incomplete; it contains only the template structure with uncompleted sections (Description and Test Coverage are empty) and does not explain the changes or their rationale. Complete the Description section explaining why Ubuntu 24.04 support is being added, and detail the Test Coverage section describing how the changes will be validated.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly indicates the main change: adding an Ubuntu 24.04 wheel image for SBSA, with proper JIRA ticket reference and infra type label.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented Mar 23, 2026

PR_Github #39870 [ run ] triggered by Bot. Commit: 07ff5eb Link to invocation

mzweilz
mzweilz approved these changes Mar 23, 2026
View reviewed changes
Comment thread docker/common/install_base.sh
Comment thread docker/common/install_tensorrt.sh
@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented Mar 23, 2026

PR_Github #39870 [ run ] completed with state FAILURE. Commit: 07ff5eb
/LLM/main/L0_MergeRequest_PR pipeline #31040 (Partly Tested) completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@niukuo niukuo force-pushed the dlfw_docker branch 2 times, most recently from a3c1fbf to 1b9832a Compare March 24, 2026 02:23
@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented Mar 24, 2026

PR_Github #40016 [ run ] triggered by Bot. Commit: 1b9832a Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented Mar 24, 2026

PR_Github #40016 [ run ] completed with state FAILURE. Commit: 1b9832a
/LLM/main/L0_MergeRequest_PR pipeline #31174 (Partly Tested) completed with status: 'FAILURE'

CI Report

⚠️ Action Required:

  • Please check the failed tests and fix your PR
  • If you cannot view the failures, ask the CI triggerer to share details
  • Once fixed, request an NVIDIA team member to trigger CI again

Link to invocation

@niukuo
Copy link
Copy Markdown
Collaborator Author

niukuo commented Mar 31, 2026

/bot skip --comment "node step passed"

@niukuo
Copy link
Copy Markdown
Collaborator Author

niukuo commented Mar 31, 2026

/bot run --stage-list "Build-Docker-Images"

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented Mar 31, 2026

PR_Github #40914 [ run ] triggered by Bot. Commit: fe4ab42 Link to invocation

@niukuo
Copy link
Copy Markdown
Collaborator Author

niukuo commented Mar 31, 2026

/bot skip --comment "tested in MR#10036"

@niukuo niukuo enabled auto-merge (squash) March 31, 2026 16:30
@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented Mar 31, 2026

PR_Github #40975 [ skip ] triggered by Bot. Commit: fe4ab42 Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

tensorrt-cicd commented Mar 31, 2026

PR_Github #40975 [ skip ] completed with state SUCCESS. Commit: fe4ab42
Skipping testing for commit fe4ab42

Link to invocation

@niukuo niukuo merged commit 70e8608 into NVIDIA:main Mar 31, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mzweilz mzweilz mzweilz approved these changes

@tburt-nv tburt-nv Awaiting requested review from tburt-nv tburt-nv is a code owner automatically assigned from NVIDIA/trt-llm-setup-infra-devs

Assignees

@niukuo niukuo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@niukuo @tensorrt-cicd @mzweilz