Skip to content

[None][infra] Waive flaky DeepSeekV3Lite disagg serving test#12518

Merged
bo-nv merged 1 commit into
NVIDIA:mainfrom
bo-nv:main-waive
Mar 25, 2026
Merged

[None][infra] Waive flaky DeepSeekV3Lite disagg serving test#12518
bo-nv merged 1 commit into
NVIDIA:mainfrom
bo-nv:main-waive

Conversation

@bo-nv
Copy link
Copy Markdown
Collaborator

@bo-nv bo-nv commented Mar 25, 2026

Summary by CodeRabbit

  • Tests
    • Added test waive for a specific accuracy test case related to serving configurations, associated with a known issue.

Description

Test Coverage

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

@bo-nv
Copy link
Copy Markdown
Collaborator Author

bo-nv commented Mar 25, 2026

/bot skip --comment "waive broken test to unblock CI"

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 25, 2026

📝 Walkthrough

Walkthrough

A single test case is added to the integration test waive list for accuracy/test_disaggregated_serving.py::TestDeepSeekV3Lite::test_auto_dtype_with_helix with specific parameterization, marking it as skipped and linking it to an existing bug reference.

Changes

Cohort / File(s) Summary
Test Waive Configuration
tests/integration/test_lists/waives.txt
Adds waive entry for TestDeepSeekV3Lite::test_auto_dtype_with_helix with fifo_v2-cudagraph:with_padding-pp2tp1cp2 parameterization, marked as SKIP with bug reference.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • liji-nv
🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is mostly empty with only the template visible. Title and critical context are present, but the Description, Test Coverage sections are not filled in. Add a clear description explaining why this test is flaky and needs to be waived. Include reference to the bug tracking issue and any relevant test coverage information.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding a waive entry for a flaky DeepSeekV3Lite disaggregated serving test, which matches the raw summary exactly.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #40199 [ skip ] triggered by Bot. Commit: d833c5b Link to invocation

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #40199 [ skip ] completed with state SUCCESS. Commit: d833c5b
Skipping testing for commit d833c5b

Link to invocation

@bo-nv bo-nv merged commit e984a7c into NVIDIA:main Mar 25, 2026
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants