You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for contributing to the Docker-Selenium project! A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Fixes#3058
New config key monitoring.exporter.tolerations
Motivation and Context
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Add missing tolerations support to the monitoring exporter Deployment so exporter pods can be scheduled (not stuck Pending) in clusters requiring tolerations.
Ensure the Helm chart exposes a configurable tolerations field for the monitoring exporter.
⚪
Validate in a real Kubernetes cluster that setting monitoring.exporter.tolerations unblocks scheduling for the exporter pod(s) on tainted/dedicated nodes (end-to-end Helm install/upgrade test).
Codebase Duplication Compliance
⚪
Codebase context is not defined
Follow the guide to enable codebase context checks.
Custom Compliance
🟢
Generic: Comprehensive Audit Trails
Objective: To create a detailed and reliable record of critical system actions for security analysis and compliance.
Why: The suggestion correctly identifies that testing with a hardcoded index is brittle and proposes a more robust check, improving test maintainability.
Low
Guard tolerations retrieval
Improve the test by safely accessing the tolerations field using .get() and adding a clear assertion message.
- tolerations = doc['spec']['template']['spec']['tolerations']- self.assertTrue(len(tolerations) > 0)+ tolerations = doc['spec']['template']['spec'].get('tolerations', [])+ self.assertTrue(tolerations, "Tolerations not defined on exporter deployment")
Apply / Chat
Suggestion importance[1-10]: 4
__
Why: The suggestion improves test robustness by safely accessing the tolerations key and adding a descriptive assertion message, though the current code is not incorrect.
Low
Learned best practice
Fix tolerations YAML indentation
Render tolerations as a YAML block (newline + proper indent) and ensure it aligns under the Pod spec (same level as containers) to avoid producing invalid inline YAML.
Why:
Relevant best practice - In Helm/YAML templates, ensure fields are rendered at the correct scope and formatted with correct indentation/newlines so the resulting YAML is valid.
The action failed during development environment setup because Docker Compose could not be downloaded and Docker became unusable on the runner: - In make setup_dev_env (Makefile:69), ./tests/charts/make/chart_setup_env.sh attempted to install Docker Compose and ran: curl -fsSL -o ./docker-compose https://github.com/docker/compose/releases/download/v5.0.2/docker-compose-linux-aarch64 which repeatedly returned curl: (22) ... 502 (Attempts 1–3), causing the script to exit with status 22 and make ... Error 22. - After the third attempt, the follow-up step make set_containerd_image_store (Makefile:78) tried to restart Docker (systemctl restart docker) but docker.service failed to start.
- Subsequent cleanup (docker system prune -af) also failed with Cannot connect to the Docker daemon at unix:///var/run/docker.sock, confirming Docker was not running and causing the job to exit with code 1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Fixes #3058
New config key
monitoring.exporter.tolerationsMotivation and Context
Types of changes
Checklist
PR Type
Enhancement, Tests
Description
Add tolerations support for monitoring exporter deployment
Enable exporter pods to run on dedicated nodes
Add test to verify tolerations configuration
Update documentation and example values
Diagram Walkthrough
File Walkthrough
values.yaml
Add tolerations configuration parametercharts/selenium-grid/values.yaml
tolerationsfield undermonitoring.exporterconfiguration[]monitoring-exporter-deployment.yaml
Apply tolerations to exporter deploymentcharts/selenium-grid/templates/monitoring-exporter-deployment.yaml
withconditional to apply tolerations when definednindent 6CONFIGURATION.md
Document exporter tolerations parametercharts/selenium-grid/CONFIGURATION.md
monitoring.exporter.tolerationsparameter[]test.py
Add test for exporter tolerationstests/charts/templates/test.py
test_monitoring_exporter_tolerationsdummy.yaml
Add tolerations to test fixturetests/charts/templates/render/dummy.yaml
dummy_solution.yaml
Add tolerations to expected outputtests/charts/templates/render/dummy_solution.yaml