extend CI to run tests with JDK 21#1408
Merged
Merged
Conversation
40a5327 to
84dbd84
Compare
Note that the plugin was passed on from `com.github.johnrengelman.shadow` to `com.gradleup.shadow`, because the original maintainer has no capacity to maintain it anymore. Signed-off-by: Peter Gafert <[email protected]>
We should rather extend the plugin instantiation logic to allow non-public constructors than making it public to be possibly invoked by users. Signed-off-by: Peter Gafert <[email protected]>
This was previously blocked by our Gradle version being too old. Now that we can run the tests with JDK 21 it shows though, that the `Annotation` `toString()` behavior has changed again. Unfortunately, this always either causes complexity on the production or test side. If we want to test the `AnnotationProxy.toString()` behavior, then either we have to add a workaround to the test code, or we have to adjust the production code to produce the equivalent `toString()` value. I opted for the latter in hopes that they will finally stop changing the `toString()` style every couple of versions. Signed-off-by: Peter Gafert <[email protected]>
84dbd84 to
1102ae9
Compare
hankem
approved these changes
Jan 20, 2025
hankem
approved these changes
Jan 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was previously blocked by our Gradle version being too old. Now that we can run the tests with JDK 21 it shows though, that the
AnnotationtoString()behavior has changed again. Unfortunately, this always either causes complexity on the production or test side. If we want to test theAnnotationProxy.toString()behavior, then either we have to add a workaround to the test code, or we have to adjust the production code to produce the equivalenttoString()value. I opted for the latter in hopes that they will finally stop changing thetoString()style every couple of versions.