Skip to content

Confirm dialog for batch actions contains an unexpected "close" button #8977

@toao

Description

@toao

Since v3.5.0 where jQuery UI was bumped to v1.14.2 there's an additional "close" button in the titlebar of the confirmation dialog of batch actions.

Expected behavior

The regular, jQuery UI based confirm dialog should be shown with just two buttons in the buttonpane: "ok" and "cancel"

Image

Actual behavior

The confirm dialog is shown but it contains an additional "close" button in the titlebar.

Image

How to reproduce

  1. Add a batch action with a confirm param, e.g.
batch_action :process, confirm: "Are you sure?" do |ids|
   head :ok
end
  1. trigger this batch action from the index

Quickfix

The quick'n'dirty fix on our side was to just hide this button via CSS for the time being 😅

.ui-dialog[aria-describedby="dialog_confirm"] .ui-dialog-titlebar-close {
  display: none;
}

Metadata

Metadata

Assignees

Labels

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions