Use keyword to: in page_routes#9020
Merged
Merged
Conversation
Convert the remaining hash-form route call in `ActiveAdmin::Router#page_routes` to the keyword `to:` form for uniformity with other route invocations and as a cleanup left over from #8837. This change is purely stylistic, it does not remove any observed Rails 8.1 deprecation warnings, does not seem to alter Rails 8.2 (edge) compatibility, and has no runtime behavior changes.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 3-0-stable #9020 +/- ##
=============================================
Coverage ? 99.19%
=============================================
Files ? 194
Lines ? 4974
Branches ? 0
=============================================
Hits ? 4934
Misses ? 40
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert the remaining hash-form route call in
ActiveAdmin::Router#page_routesto the keywordto:form for uniformity with other route invocations and as a cleanup left over from #8837.This change is purely stylistic, it does not remove any observed Rails 8.1 deprecation warnings, does not seem to alter Rails 8.2 (edge) compatibility, and has no runtime behavior changes.