Fix XSS in rendered report: HTML-escape user-controlled reportName#3334
Merged
baev merged 3 commits intoMay 11, 2026
Merged
Conversation
FreemarkerContext constructs the FreeMarker Configuration without an
output format, so HTML auto-escaping is off. The reportName value
(set via ConfigurationBuilder#withReportName, ultimately controlled
by the user's CLI invocation or upstream config) is interpolated into
the <title> tag in index.html.ftl with no escaping, so a value
containing live HTML or JS is rendered raw.
Apply per-variable HTML escaping at the bug site:
<title>${(reportName!"Allure Report")?html}</title>
A broader change to the Configuration's output format would tighten
escaping across every template variable, but it would need a
template-wide audit first (especially for ${...} interpolations
inside <script> tags). Out of scope here; tracked separately.
Adds ReportWebGeneratorTest#shouldEscapeHtmlInReportName, which fails
on main and passes with this change.
Co-Authored-By: Claude Opus 4.7 <[email protected]>
2 tasks
baev
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
FreemarkerContextconstructs the FreeMarkerConfigurationwithout an output format, so HTML auto-escaping is off. ThereportNamevalue (set viaConfigurationBuilder#withReportName, ultimately controlled by the user's CLI invocation or upstream config) is interpolated into the<title>tag inindex.html.ftlwith no escaping, so a value containing live HTML or JS is rendered raw.This PR applies per-variable HTML escaping at the bug site:
A broader change to the
Configuration's output format would tighten escaping across every template variable, but it would need a template-wide audit first (especially for${...}interpolations inside<script>tags). That's intentionally out of scope here and worth its own discussion.Checklist