Skip to content

[fix](fe) Skip broken external tables in show tables#63407

Merged
Gabriel39 merged 1 commit into
apache:masterfrom
suxiaogang223:fix-show-tables-broken-tables-cir-20192
May 20, 2026
Merged

[fix](fe) Skip broken external tables in show tables#63407
Gabriel39 merged 1 commit into
apache:masterfrom
suxiaogang223:fix-show-tables-broken-tables-cir-20192

Conversation

@suxiaogang223
Copy link
Copy Markdown
Member

@suxiaogang223 suxiaogang223 commented May 19, 2026 •
edited
Loading

What problem does this PR solve?

Issue Number: close #xxx

Related PR: None

Problem Summary:
SHOW TABLES on external catalogs can fail for the whole database when a single table throws during metadata initialization or schema parsing. This change skips the broken table in the SHOW TABLES path so other tables remain visible.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • Previous test can cover this change.

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

@suxiaogang223
[fix](fe) Skip broken external tables in show tables
4f0b17f 
SHOW TABLES on external catalogs can fail for the whole database when a single table throws during metadata initialization or schema parsing. This change skips the broken table in the SHOW TABLES path so other tables remain visible.

Ported from CIR-20192.
@hello-stephen
Copy link
Copy Markdown
Contributor

hello-stephen commented May 19, 2026

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@suxiaogang223
Copy link
Copy Markdown
Member Author

suxiaogang223 commented May 19, 2026

run buildall

@suxiaogang223 suxiaogang223 requested a review from morningman May 19, 2026 10:56
@hello-stephen
Copy link
Copy Markdown
Contributor

hello-stephen commented May 19, 2026

TPC-H: Total hot run time: 31389 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4f0b17f999f04b5ac9eba776680370d7e3cefe6e, data reload: false

------ Round 1 ----------------------------------
orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	17616	3898	3900	3898
q2	q3	10761	1337	797	797
q4	4702	473	345	345
q5	7593	2276	2150	2150
q6	235	177	139	139
q7	918	784	638	638
q8	9367	1678	1575	1575
q9	5224	4936	4951	4936
q10	6388	2078	1809	1809
q11	440	274	260	260
q12	627	423	296	296
q13	18100	3358	2769	2769
q14	259	255	238	238
q15	q16	823	771	704	704
q17	906	942	964	942
q18	6886	5861	5628	5628
q19	1348	1218	1008	1008
q20	503	403	333	333
q21	6422	2861	2601	2601
q22	469	370	323	323
Total cold run time: 99587 ms
Total hot run time: 31389 ms

----- Round 2, with runtime_filter_mode=off -----
orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
============================================
q1	4799	4630	4576	4576
q2	q3	4919	5265	4651	4651
q4	2130	2179	1421	1421
q5	4735	4762	4603	4603
q6	233	184	131	131
q7	1840	1773	1517	1517
q8	2403	2051	2046	2046
q9	7730	7631	7185	7185
q10	4460	4414	3985	3985
q11	538	377	350	350
q12	712	723	515	515
q13	2999	3364	2804	2804
q14	281	279	259	259
q15	q16	684	698	614	614
q17	1248	1230	1221	1221
q18	7372	6847	6800	6800
q19	1089	1075	1116	1075
q20	2205	2201	1948	1948
q21	5314	4601	4495	4495
q22	524	466	401	401
Total cold run time: 56215 ms
Total hot run time: 50597 ms

@hello-stephen
Copy link
Copy Markdown
Contributor

hello-stephen commented May 19, 2026

TPC-DS: Total hot run time: 170713 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4f0b17f999f04b5ac9eba776680370d7e3cefe6e, data reload: false

query5	4330	643	531	531
query6	342	232	200	200
query7	4289	562	317	317
query8	346	246	227	227
query9	8812	4055	4052	4052
query10	439	335	297	297
query11	5776	2336	2220	2220
query12	188	133	131	131
query13	1253	570	424	424
query14	6031	5300	5005	5005
query14_1	4351	4376	4308	4308
query15	208	207	182	182
query16	1019	461	382	382
query17	1130	743	621	621
query18	2488	489	361	361
query19	223	205	170	170
query20	140	134	133	133
query21	219	142	117	117
query22	13611	13481	13355	13355
query23	17089	16272	16093	16093
query23_1	16234	16172	16221	16172
query24	7532	1777	1305	1305
query24_1	1324	1318	1314	1314
query25	598	514	455	455
query26	1305	315	178	178
query27	2719	546	343	343
query28	4447	1967	1965	1965
query29	986	656	529	529
query30	308	240	199	199
query31	1128	1058	936	936
query32	100	77	74	74
query33	557	375	306	306
query34	1155	1123	651	651
query35	777	779	678	678
query36	1356	1315	1159	1159
query37	155	103	96	96
query38	3221	3135	3041	3041
query39	938	939	897	897
query39_1	878	904	868	868
query40	241	152	131	131
query41	72	72	69	69
query42	113	115	112	112
query43	328	328	288	288
query44	
query45	211	203	200	200
query46	1052	1175	743	743
query47	2300	2306	2188	2188
query48	423	433	307	307
query49	654	526	411	411
query50	983	348	254	254
query51	4277	4333	4226	4226
query52	107	108	98	98
query53	258	284	224	224
query54	328	300	279	279
query55	97	94	88	88
query56	337	325	328	325
query57	1437	1445	1328	1328
query58	303	274	275	274
query59	1583	1642	1480	1480
query60	323	329	308	308
query61	163	159	163	159
query62	672	611	565	565
query63	243	197	209	197
query64	2408	798	654	654
query65	
query66	1712	487	345	345
query67	30012	29999	29785	29785
query68	
query69	473	343	304	304
query70	1049	998	1011	998
query71	305	278	270	270
query72	3050	2679	2639	2639
query73	831	740	421	421
query74	5096	4881	4718	4718
query75	2710	2616	2262	2262
query76	2281	1117	734	734
query77	406	417	333	333
query78	12149	12159	11534	11534
query79	1456	1033	758	758
query80	642	551	455	455
query81	456	279	243	243
query82	1326	163	124	124
query83	344	269	248	248
query84	262	140	108	108
query85	873	534	443	443
query86	407	360	318	318
query87	3446	3375	3201	3201
query88	3531	2654	2660	2654
query89	450	382	336	336
query90	1900	177	179	177
query91	178	165	140	140
query92	80	79	76	76
query93	1608	1527	883	883
query94	529	355	327	327
query95	687	404	435	404
query96	1043	806	346	346
query97	2733	2699	2574	2574
query98	241	236	231	231
query99	1112	1126	980	980
Total cold run time: 253280 ms
Total hot run time: 170713 ms

@hello-stephen
Copy link
Copy Markdown
Contributor

hello-stephen commented May 19, 2026

FE UT Coverage Report

Increment line coverage 33.33% (2/6) 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Copy Markdown
Contributor

hello-stephen commented May 19, 2026

FE Regression Coverage Report

Increment line coverage 33.33% (2/6) 🎉
Increment coverage report
Complete coverage report

@Gabriel39
Copy link
Copy Markdown
Contributor

Gabriel39 commented May 20, 2026

/review

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label May 20, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 20, 2026

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 20, 2026

PR approved by anyone and no changes requested.

@Gabriel39 Gabriel39 merged commit 2a28561 into apache:master May 20, 2026
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gabriel39 Gabriel39 Gabriel39 approved these changes

@morningman morningman Awaiting requested review from morningman

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@suxiaogang223 @hello-stephen @Gabriel39