Skip to content

fix(cli): show sync wait dependencies#25089

Merged
SasSwart merged 4 commits into
coder:mainfrom
maschwenk:maschwenk/sync-wait-output
May 14, 2026
Merged

fix(cli): show sync wait dependencies#25089
SasSwart merged 4 commits into
coder:mainfrom
maschwenk:maschwenk/sync-wait-output

Conversation

@maschwenk
Copy link
Copy Markdown
Contributor

@maschwenk maschwenk commented May 8, 2026

Problem

coder exp sync want and coder exp sync start both printed generic success messages, which hid the dependency units involved in startup coordination.

Before, declaring dependencies with sync want printed:

Success

Before, sync start printed while waiting, then finished with another generic success message:

Waiting for dependencies of unit 'test-unit' to be satisfied...
Success

Solution

Print the dependency units in both cases, using wording that matches where the command is in the lifecycle.

After, sync want prints the dependencies it declared for the unit:

Unit "test-unit" declared dependencies: [dep-unit]

After, sync start enumerates the dependencies while it is waiting, then prints the same dependencies after the unit starts executing:

Unit "test-unit" is waiting for dependencies to be satisfied: [dep-unit, dep-unit-2]
Unit "test-unit" finished waiting for dependencies: [dep-unit, dep-unit-2]

The sync golden tests now cover the updated output, including multiple dependencies for sync start.

@github-actions github-actions Bot added the community Pull Requests and issues created by the community. label May 8, 2026
@maschwenk maschwenk marked this pull request as ready for review May 8, 2026 15:59
Comment thread cli/testdata/TestSyncCommands_Golden/start_with_dependencies.golden Outdated
@matifali matifali requested a review from SasSwart May 8, 2026 17:36
@SasSwart SasSwart merged commit f3e90b3 into coder:main May 14, 2026
30 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators May 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cherry-pick community Pull Requests and issues created by the community.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants