fix(coderd/taskname): parse task name JSON with trailing text (#25005)#25300
Merged
Conversation
Anthropic task name responses can include valid JSON followed by a closing fence or extra text, which made `json.Unmarshal` fail with trailing-character errors and forced fallback naming. This updates task name JSON extraction to accept the first JSON value after optional fences and adds regression coverage for fenced and bare JSON with trailing content. (cherry picked from commit 87d580d)
Contributor
There was a problem hiding this comment.
Pull request overview
Fix task name JSON parsing to handle Anthropic responses where valid JSON is followed by trailing text (e.g., closing fence or commentary), which previously broke json.Unmarshal and forced fallback naming.
Changes:
- Replace ad-hoc fence-stripping with a regex that tolerates trailing content after the closing fence.
- After fence stripping, decode the first JSON value via
json.Decoderand return its raw form, ignoring trailing text. - Add regression tests covering fenced/bare JSON with trailing fences or commentary.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| coderd/taskname/taskname.go | Adds regex for markdown fence handling and uses a JSON decoder to extract the first JSON value. |
| coderd/taskname/taskname_internal_test.go | Adds test cases for fenced/bare JSON with trailing text or trailing fence. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
matifali
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Anthropic task name responses can include valid JSON followed by a closing fence or extra text, which made
json.Unmarshalfail with trailing-character errors and forced fallback naming.This updates task name JSON extraction to accept the first JSON value after optional fences and adds regression coverage for fenced and bare JSON with trailing content.
(cherry picked from commit 87d580d)