Skip to content

Letter 'a' from #428 (replaces #430)#448

Merged
larsoner merged 2 commits into
codespell-project:masterfrom
luzpaz:latter-a-libreoffice-list
Apr 26, 2018
Merged

Letter 'a' from #428 (replaces #430)#448
larsoner merged 2 commits into
codespell-project:masterfrom
luzpaz:latter-a-libreoffice-list

Conversation

@luzpaz
Copy link
Copy Markdown
Collaborator

@luzpaz luzpaz commented Apr 14, 2018

(FYI: This PR is a revision on #430 whereby non-'a' letters have been removed and other tweeks have been made)
Started to separate #428 in to discrete PRs for each letter. Also removed/corrected some entries that were not relevant/precise. This PR has been sorted as well.

@luzpaz luzpaz mentioned this pull request Apr 14, 2018
@codecov-io
Copy link
Copy Markdown

codecov-io commented Apr 14, 2018

Codecov Report

Merging #448 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #448   +/-   ##
=======================================
  Coverage   87.81%   87.81%           
=======================================
  Files           2        2           
  Lines         665      665           
  Branches       93       93           
=======================================
  Hits          584      584           
  Misses         62       62           
  Partials       19       19

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4a5834...78421f4. Read the comment docs.

@luzpaz luzpaz force-pushed the latter-a-libreoffice-list branch from 80a48ea to 6ee00e3 Compare April 14, 2018 10:04
Comment thread codespell_lib/data/dictionary.txt Outdated
alow->allow
alowed->allowed
alowing->allowing
alowinserts->allowinserts
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be removed

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

Comment thread codespell_lib/data/dictionary.txt Outdated
applicaitons->applications
applicaten->application
applicatin->application
applicationevnet->applicationevent
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be removed

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@luzpaz luzpaz force-pushed the latter-a-libreoffice-list branch 3 times, most recently from 327cb65 to fe7d763 Compare April 17, 2018 13:14
@luzpaz
Copy link
Copy Markdown
Collaborator Author

luzpaz commented Apr 17, 2018

@EdwardBetts do you mind reviewing this PR? Thanks!

@luzpaz luzpaz force-pushed the latter-a-libreoffice-list branch from fe7d763 to ac07542 Compare April 24, 2018 12:47
@luzpaz
Copy link
Copy Markdown
Collaborator Author

luzpaz commented Apr 24, 2018

@larsoner would you like me to further break this PR apart so it's not so large ?

@luzpaz luzpaz force-pushed the latter-a-libreoffice-list branch from ac07542 to a51637a Compare April 24, 2018 15:29
@larsoner
Copy link
Copy Markdown
Member

Now it needs a rebase at least

@luzpaz luzpaz force-pushed the latter-a-libreoffice-list branch from a51637a to c337be3 Compare April 24, 2018 16:08
@luzpaz
Copy link
Copy Markdown
Collaborator Author

luzpaz commented Apr 24, 2018

Done

Comment thread codespell_lib/data/dictionary.txt Outdated
applictions->applications
applikation->application
appling->applying, appalling,
applyable->applycable
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be applyable->applicable.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct sir. Thank you. Will fix and push revision

(FYI: This PR is a revision on codespell-project#430 whereby non-'a' letters have been removed and other tweeks have been made)
Started to separate codespell-project#428 in to discrete PRs for each letter. Also removed/corrected some entries that were not relevant/precise. This PR has been sorted as well.
@luzpaz luzpaz force-pushed the latter-a-libreoffice-list branch from c337be3 to 2841ea3 Compare April 26, 2018 14:53
@luzpaz
Copy link
Copy Markdown
Collaborator Author

luzpaz commented Apr 26, 2018

Should be ready for merge, AFAICT

Comment thread codespell_lib/data/dictionary.txt Outdated
aproximately->approximately
aproximation->approximation
aproximations->approximations
aprrovement->approvement
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word approvement is archaic, it isn't known by my the Firefox spell checker. I feel like we shouldn't be encouraging programmers to use it. Approval is a better choice of word.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Changed

Comment thread codespell_lib/data/dictionary.txt Outdated
anthromorphization->anthropomorphization
anthropolgist->anthropologist
anthropolgy->anthropology
antialialised->antialialiased
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Antialialiased isn't a word, it should be antialiased.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Fixed

@larsoner larsoner merged commit 602b97d into codespell-project:master Apr 26, 2018
@luzpaz luzpaz deleted the latter-a-libreoffice-list branch April 26, 2018 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants