add global options to healthcheck command#4575
Merged
Merged
Conversation
61bf0a1 to
df9ff8c
Compare
AkihiroSuda
reviewed
Oct 31, 2025
AkihiroSuda
reviewed
Oct 31, 2025
AkihiroSuda
requested changes
Oct 31, 2025
df9ff8c to
27318a4
Compare
Shubhranshu153
approved these changes
Nov 3, 2025
AkihiroSuda
reviewed
Nov 4, 2025
654a56b to
e1b158d
Compare
| // 1. It was explicitly changed via CLI (highest priority), OR | ||
| // 2. It has a non-default value (from TOML config) | ||
| // This ensures both CLI flags and TOML config values are propagated | ||
| if f.Changed || (val != f.DefValue && val != "") { |
Contributor
There was a problem hiding this comment.
This condition i think should not be there, the function seems to return all global flags, irrespective of changed or not changed. Not sure if this condition is required.
@AkihiroSuda Do you happen to know why we have the condition for compose.
Signed-off-by: Arjun Raja Yogidas <[email protected]>
Signed-off-by: Arjun Raja Yogidas <[email protected]>
Signed-off-by: Arjun Raja Yogidas <[email protected]>
Signed-off-by: Arjun Raja Yogidas <[email protected]>
e1b158d to
89fc035
Compare
Contributor
Author
|
Rebased and added logic to pass through any config file env variables to the systemd commands. This should enable clients like finch to utilize the nerdctl healthchecks. |
Shubhranshu153
approved these changes
Nov 13, 2025
Contributor
|
Line 13 in 2165e30 Should we |
AkihiroSuda
approved these changes
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the global flags passed to nerdclt is not passed to the healthcheck command, this results in container not found errors while running healthchecks in a namespaced environement
This PR passes the global options to the healthcheck command as well