Skip to content

allow cte in CREATE VIEW#2353

Merged
jennifersp merged 4 commits into
mainfrom
jennifer/view-cte
Feb 20, 2026
Merged

allow cte in CREATE VIEW#2353
jennifersp merged 4 commits into
mainfrom
jennifer/view-cte

Conversation

@jennifersp
Copy link
Copy Markdown
Contributor

@jennifersp jennifersp commented Feb 19, 2026

Also fixes:

  • string_agg with separator cast with text type
  • fix parse procedure and sequence name in GRANT privileges ON statement

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 19, 2026

Main PR
covering_index_scan_postgres 555.52/s 552.66/s -0.6%
index_join_postgres 124.01/s 124.93/s +0.7%
index_join_scan_postgres 185.09/s 185.91/s +0.4%
index_scan_postgres 11.37/s 11.51/s +1.2%
oltp_point_select 2335.04/s 2397.11/s +2.6%
oltp_read_only 1711.19/s 1728.56/s +1.0%
select_random_points 111.23/s 112.97/s +1.5%
select_random_ranges 406.09/s 418.93/s +3.1%
table_scan_postgres 11.19/s 11.18/s -0.1%
types_table_scan_postgres 5.25/s 5.30/s +0.9%

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 19, 2026

Main PR
Total 42090 42090
Successful 17642 17642
Failures 24448 24448
Partial Successes1 5572 5572
Main PR
Successful 41.9149% 41.9149%
Failures 58.0851% 58.0851%

${\color{red}Regressions (2)}$

limit

QUERY:          CREATE VIEW limit_thousand_v_2 AS SELECT thousand FROM onek WHERE thousand < 995
		ORDER BY thousand OFFSET 10 FETCH FIRST 5 ROWS ONLY;
RECEIVED ERROR: invalid type: bigint (errno 1105) (sqlstate HY000)

updatable_views

QUERY:          CREATE VIEW ro_view8 AS SELECT a, b FROM base_tbl ORDER BY a OFFSET 1;
RECEIVED ERROR: invalid type: bigint (errno 1105) (sqlstate HY000)

${\color{lightgreen}Progressions (2)}$

updatable_views

QUERY: CREATE VIEW ro_view7 AS WITH t AS (SELECT a, b FROM base_tbl) SELECT * FROM t;

with

QUERY: CREATE VIEW sums_1_100 AS
WITH RECURSIVE t(n) AS (
    VALUES (1)
UNION ALL
    SELECT n+1 FROM t WHERE n < 100
)
SELECT sum(n) FROM t;

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct.

Copy link
Copy Markdown
Collaborator

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jennifersp jennifersp merged commit 8580556 into main Feb 20, 2026
17 checks passed
@jennifersp jennifersp deleted the jennifer/view-cte branch February 20, 2026 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants