[release/10.0] Do not store result of cast in IDynIntfCastable scenarios#125637
Merged
Conversation
Refactor cache update logic to avoid unnecessary updates for IDynamicInterfaceCastable types.
jkotas
approved these changes
Mar 16, 2026
Member
|
/ba-g all failures known |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #125605 to release/10.0
/cc @MichalStrehovsky
Customer Impact
Hit by the Windows team in #125577. CsWinRT previously didn't use IDynamicInterfaceCastable for casting much. In 3.0, it's going to fully lean into it and this will be a problem.
Regression
Regressed in .NET 9.0 in #108328 where we were fixing a different caching issue and introduced a new bug ("I also fixed the other checks for consistency" in the PR - these were all bugs).
Testing
This was missed because it's a caching issue. We need to cache a result and then return wrong result from the cache on a subsequent type check that should behave differently. We now have a test specifically exercising the cache.
Risk
This is low risk, we're adding a condition for caching and the condition is scoped to just the bug scenario.
IMPORTANT: If this backport is for a servicing release, please verify that:
release/X.0-staging, notrelease/X.0.release/X.0(no-stagingsuffix).Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.