This repository was archived by the owner on Aug 30, 2023. It is now read-only.
fix: envelope header has sdkVersion and not sdkInfo#488
Merged
marandaneto merged 4 commits intoJul 21, 2020
Conversation
Member
philipphofmann
left a comment
There was a problem hiding this comment.
Good job 👏 , I added a few comments.
Comment on lines
+50
to
+51
| // TODO: sentry-core should add itself as the version may mismatch | ||
| sdkVersion.addPackage("maven:sentry-core", version); |
Member
There was a problem hiding this comment.
Created issue to follow up: https://github.com/getsentry/sentry-java/projects/1#card-42202340
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
fix: envelope header has sdkVersion and not sdkInfo
💡 Motivation and Context
getsentry/develop#89
docs were wrong about which object to use
💚 How did you test it?
📝 Checklist
🔮 Next steps