Add method to add breadcrumb with string parameter.#500
Conversation
|
Oh, what about this also going to |
|
I'm good if it goes to Switching base is unfortunately not as straightforward. If @marandaneto has no objections I'll close this one and create another PR against |
|
Makes sense to be on the safe side. This is just an overload so not a breaking change though I believe the main concern are things that would need to be tested on different Android version (yup) to make sure things continue to work. Because, Android. Things like this overload IMO are safe and will make it simpler later for us to merge things from the java branch and master since a lot of code not ok to merge into master will follow. @marandaneto thoughts? |
yep, agreed, it's just an overload, things like this are LGTM |
|
Closed in favour of #501. |
📢 Type of change
📜 Description
Add method to add breadcrumb with string parameter.
💡 Motivation and Context
See #499 (comment)
💚 How did you test it?
There's a unit test.
📝 Checklist
🔮 Next steps