Skip to content

feat(Nitro): Nitro SDK#17983

Closed
logaretm wants to merge 47 commits into
developfrom
awad/nitro-sdk
Closed

feat(Nitro): Nitro SDK#17983
logaretm wants to merge 47 commits into
developfrom
awad/nitro-sdk

Conversation

@logaretm
Copy link
Copy Markdown
Member

@logaretm logaretm commented Oct 21, 2025

No description provided.

github-advanced-security[bot]
github-advanced-security AI found potential problems Oct 21, 2025
View reviewed changes
Comment thread packages/nitro/src/utils/codemod.ts
*/
export function getFilenameFromNodeStartCommand(nodeCommand: string): string | null {
const regex = /[^/\\]+\.[^/\\]+$/;
const match = nodeCommand.match(regex);

Check failure

Code scanning / CodeQL

Polynomial regular expression used on uncontrolled data High

This
regular expression
Loading
that depends on
library input
Loading
may run slow on strings with many repetitions of '.'.
This
regular expression
Loading
that depends on
library input
Loading
may run slow on strings starting with '..' and with many repetitions of '..'.
This
regular expression
Loading
that depends on
library input
Loading
may run slow on strings with many repetitions of '.'.
This
regular expression
Loading
that depends on
library input
Loading
may run slow on strings starting with '..' and with many repetitions of '..'.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 21, 2025 •
edited
Loading

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 8,740 - 8,869 -1%
GET With Sentry 1,374 16% 1,384 -1%
GET With Sentry (error only) 6,186 71% 6,192 -0%
POST Baseline 1,211 - 1,177 +3%
POST With Sentry 508 42% 529 -4%
POST With Sentry (error only) 1,058 87% 1,060 -0%
MYSQL Baseline 3,320 - 3,381 -2%
MYSQL With Sentry 443 13% 493 -10%
MYSQL With Sentry (error only) 2,718 82% 2,725 -0%

View base workflow run

logaretm added 28 commits October 22, 2025 15:04
@logaretm
feat: initial impl
f5b0e4b
@logaretm
feat: added sdk initializer
c3f7d27
@logaretm
fix: hook installation
f5821e4
@logaretm
docs: comment
e214fea
@logaretm
refactor: use module
43e4f49
@logaretm
feat: port the server response renderer logic
f5e46c4
@logaretm
feat: full port except for sourcemaps
a7a1a8c
@logaretm
feat: use the nitro module in nuxt
9d7a1aa
@logaretm
fix: allow accepting a custom serverfile
035a8a2
@logaretm
fix: plugins type
963b20b
@logaretm
debug server entry issues
501955b
@logaretm
fix: update stuff
2d0d90d
@logaretm
fix: types
f6baa4d
@logaretm
fix: bump release
503d2f9
@logaretm
test: moved tests to nitro
3082cf9
@logaretm
fix: database option path
1567b56
@logaretm
fix: add sentry meta tags to html responses
6fefddc
@logaretm
style: remove a lint ignore
e17a54b
@logaretm
fix: ignore registering plugins in dev mode
a31a8e3
@logaretm
fix: no need for renderer before
bcf6acd
@logaretm
fix: build issues
2269d53
@logaretm
feat: expose an integration fn
8b692b1
@logaretm
fix: plugin init
04f49ec
@logaretm
refactor: normalize logs
a267761
@logaretm
docs: basic readme for nitro
4e12296
@logaretm
feat: updated attributes to reference nitro instead of nuxt
55db57c
@logaretm
feat: implement sourcemap setup
0dd30cf
@logaretm
tests: update nuxt 3 tests
2f80a68
@logaretm
Copy link
Copy Markdown
Member Author

logaretm commented Oct 23, 2025 •
edited
Loading

As per our team discussion, we decided to shelve this until we figure out the timeline and details of upcoming tracing channel support in Nitro and UNJS.

Closing this PR for now, but this is the current state if we need to reference it later:

  • It only adds a new Nitro SDK without using it as a dependency for Nuxt SDK, so it won't affect Nuxt users if published.
  • Needs E2E tests for basic handlers, global error handler, middlewares, storage, cache and database.
  • Need to work on sourcemap support, the wizard are detecting and upload the files as we expect but they don't get processed correctly on sass atm.

We can pick this up again, and perhaps could have a chance to only do it for v3 that's coming out soon.

@logaretm logaretm closed this Oct 23, 2025
@logaretm logaretm mentioned this pull request Nov 16, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@logaretm @github-advanced-security