Prevent where command from following symlinks out of repo#188
Merged
Conversation
searchFileForPackage used os.Open with an absolute path, which follows symlinks. A symlink named like a manifest file could point outside the repository and leak file contents. Uses os.Root scoped to the working directory so the kernel rejects any path that resolves outside the repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
`searchFileForPackage` used `os.Open` with an absolute path, which follows symlinks. A symlink named like a manifest file (e.g. `package-lock.json`) could point outside the repository and leak matching lines.
Uses `os.Root` scoped to the working directory so the kernel rejects any path that resolves outside the repo boundary. Same approach as PR #174.