Strip control characters from externally sourced strings before TTY output#189
Merged
Conversation
…utput Changelog text fetched from upstream repos, OSV summary/details fields, parsed dependency names from lockfiles, and git commit metadata all reach the terminal with C0 control bytes intact, allowing ANSI/OSC sequence injection (cursor movement, screen clearing, OSC 8 hyperlinks, clipboard writes on terminals that honour OSC 52). Adds a Sanitize helper in cmd/output.go that strips control characters other than tab and newline, applied at each cited output site.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog text fetched from upstream repositories, OSV `summary`/`details` fields, dependency names parsed from lockfiles, file content from `where`, and git commit author/message all reach the terminal with C0 control bytes intact. A hostile package author or commit author can embed ANSI/OSC escape sequences to clear the screen, move the cursor over earlier output, set the terminal title, inject OSC 8 hyperlinks, or write the clipboard on terminals that honour OSC 52.
Adds `Sanitize` in `cmd/output.go` which strips control characters other than `\t`/`\n` via `strings.Map` + `unicode.IsControl`, and applies it at the output sites in `changelog.go`, `vulns.go`, `diff_driver.go`, `where.go`, and `history.go`.