git: worktree, fix treeContainsDirs test to build a new tree for each…#2047
Merged
Conversation
… test case
This makes the TestTreeContainsDirs test more robust by ensuring that
each test case operates on a fresh tree instance. This prevents any
unintended side effects from previous test cases.
The treeContainsDirs function may write to the tree and cause a race
condition when a single tree is shared across multiple test cases. By
building a new tree for each test case, we ensure that the tests are
isolated and can be run in parallel without interference.
See tree.go:185-189:
func (t *Tree) entry(baseName string) (*TreeEntry, error) {
if t.m == nil { // read t.m
t.buildMap() // write t.m
}
entry, ok := t.m[baseName] // read t.m
Signed-off-by: Ayman Bagabas <[email protected]>
pjbgf
approved these changes
May 1, 2026
Member
pjbgf
left a comment
There was a problem hiding this comment.
@aymanbagabas thanks for working on this. 🙇
@onee-only thanks for the initial review. 🥇
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… test case
This makes the TestTreeContainsDirs test more robust by ensuring that each test case operates on a fresh tree instance. This prevents any unintended side effects from previous test cases.
The treeContainsDirs function may write to the tree and cause a race condition when a single tree is shared across multiple test cases. By building a new tree for each test case, we ensure that the tests are isolated and can be run in parallel without interference.
See tree.go:185-189:
Fixes: https://github.com/go-git/go-git/actions/runs/25163491857/job/73763612343?pr=2014