Skip to content

adding optional_field in Serializermutation to enfore some fields to be optional #1455

Merged
firaskafri merged 8 commits into
graphql-python:mainfrom
mahmoudmostafa0:main
Aug 27, 2023
Merged

adding optional_field in Serializermutation to enfore some fields to be optional #1455
firaskafri merged 8 commits into
graphql-python:mainfrom
mahmoudmostafa0:main

Conversation

@mahmoudmostafa0
Copy link
Copy Markdown
Contributor

@mahmoudmostafa0 mahmoudmostafa0 commented Aug 24, 2023

i want to use rest_framework Serializermutation and i want to force some fields to be optional

@mahmoudmostafa0
Copy link
Copy Markdown
Contributor Author

mahmoudmostafa0 commented Aug 24, 2023

this was available in v2 however i found it removed in v3

@mahmoudmostafa0 mahmoudmostafa0 changed the title adding optional_field to enfore some fields to be optional adding optional_field in Serializermutation to enfore some fields to be optional Aug 25, 2023
kiendang
kiendang reviewed Aug 25, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@kiendang kiendang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mahmoudmostafa0. There's a small typo there. Also could you run the linting as well (tox -e pre-commit)?

Comment thread graphene_django/rest_framework/mutation.py Outdated
@mahmoudmostafa0
Copy link
Copy Markdown
Contributor Author

mahmoudmostafa0 commented Aug 26, 2023

thanks @kiendang for reviewing I`ve tried out the linting and this is the final results I got :

check for merge conflicts................................................Passed
check json...............................................................Passed
check yaml...............................................................Passed
debug statements (python)................................................Passed
fix end of files.........................................................Passed
pretty format json.......................................................Passed
trim trailing whitespace.................................................Passed
black....................................................................Passed
ruff.....................................................................Passed
pre-commit: OK (6.86=setup[0.05]+cmd[6.81] seconds)
congratulations :) (9.61 seconds)

kiendang
kiendang approved these changes Aug 27, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@kiendang kiendang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Need another set of eyes though.

This is the same as #1080 which was merged into v2.

@firaskafri firaskafri merged commit e49a01c into graphql-python:main Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@firaskafri firaskafri firaskafri approved these changes

@sjdemartini sjdemartini Awaiting requested review from sjdemartini

+1 more reviewer

@kiendang kiendang kiendang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mahmoudmostafa0 @firaskafri @kiendang