Support omp threadpool#170
Merged
Merged
Conversation
ibhati
reviewed
Aug 13, 2025
Member
ibhati
left a comment
There was a problem hiding this comment.
To be consistent, can we follow the same pattern as SVS_ENABLE_NUMA for SVS_ENABLE_OMP as well? And that way also use it through SVS_VALIDATE_BOOL_ENV as done here https://github.com/intel/ScalableVectorSearch/blob/main/include/svs/lib/threads/threadpool.h#L117
ibhati
approved these changes
Aug 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new OpenMP thread pool,
OMPThreadPool, designed for users who wish to utilize OpenMP threading.