Skip to content

1.4.7 opt chaining update from ENG#419

Merged
joaquinelio merged 2 commits into
javascript-tutorial:masterfrom
joaquinelio:chino
Oct 21, 2020
Merged

1.4.7 opt chaining update from ENG#419
joaquinelio merged 2 commits into
javascript-tutorial:masterfrom
joaquinelio:chino

Conversation

@joaquinelio
Copy link
Copy Markdown
Member

https://es.javascript.info/optional-chaining

habia un err no visible de formato en ejemplo antes del resumen

Copy link
Copy Markdown
Contributor

@vplentinax vplentinax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pequeñas cositas

Comment thread 1-js/04-object-basics/07-optional-chaining/article.md Outdated
Comment thread 1-js/04-object-basics/07-optional-chaining/article.md Outdated
@javascript-translate-bot
Copy link
Copy Markdown

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@joaquinelio
Copy link
Copy Markdown
Member Author

/done

@joaquinelio
Copy link
Copy Markdown
Member Author

joaquinelio commented Oct 15, 2020

Es mayor responsabilidad del traductor hacer cambios español a español, en review no comparas con el inglés original.

No veo como mejorarlo.
La manera perfecta de review sería bajando el branch y compararlo con lens, pero es una locura no puedo pedir eso para cada modificación.

Más convencido cada vez, la sync delega,
que el artículo se haga sin apuro.
Y la review, con la profundidad que considere el reviewer sin la presion del tiempo/conflictos.

Copy link
Copy Markdown
Contributor

@vplentinax vplentinax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@joaquinelio joaquinelio merged commit 763cc97 into javascript-tutorial:master Oct 21, 2020
@joaquinelio joaquinelio deleted the chino branch October 21, 2020 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants