Skip to content

Add SecCopyErrorMessageString for iOS and update README for iOS#6862

Merged
ethomson merged 13 commits into
libgit2:mainfrom
Kyle-Ye:optimize/ios
Sep 26, 2024
Merged

Add SecCopyErrorMessageString for iOS and update README for iOS#6862
ethomson merged 13 commits into
libgit2:mainfrom
Kyle-Ye:optimize/ios

Conversation

@Kyle-Ye
Copy link
Copy Markdown
Contributor

@Kyle-Ye Kyle-Ye commented Aug 17, 2024 •
edited
Loading

  • Add iOS build instruction in README
  • Fix iOS build issue
  • Add SecCopyErrorMessageString API when building for iOS

Close #6861

@Kyle-Ye
Copy link
Copy Markdown
Contributor Author

Kyle-Ye commented Aug 18, 2024 •
edited
Loading

Some notes for the reviewer:

  1. Do we want to add iOS CI check here?
  2. There is a flaky Windows test case failing. Maybe a rerun will temporary pass it.
    Experimental Features / Build: Windows (SHA256, amd64, Visual Studio) (pull_request)
  3. The iOS CI is failing due to a permission issue
ln: /usr/local/lib: Permission denied

I'll align the host os to macos-12 as the same version of the existing macOS CI to try to fix it.

  1. Is it OK have a dependency on master branch of eetal/ios-cmake for the iOS CI?

@Kyle-Ye Kyle-Ye force-pushed the optimize/ios branch 2 times, most recently from 3a8ba3c to d7dc82f Compare August 24, 2024 06:25
@Uncommon
Copy link
Copy Markdown
Contributor

Uncommon commented Sep 5, 2024

Are these changes actually specific to iOS, or do they apply to macOS as well?

@Kyle-Ye
Copy link
Copy Markdown
Contributor Author

Kyle-Ye commented Sep 5, 2024

Are these changes actually specific to iOS, or do they apply to macOS as well?

specific to iOS

@Kyle-Ye Kyle-Ye marked this pull request as ready for review September 5, 2024 16:29
@Kyle-Ye
Copy link
Copy Markdown
Contributor Author

Kyle-Ye commented Sep 5, 2024 •
edited
Loading

The CI is failing due to libgit2_tests issue.

It will be build/libgit2_tests.app/libgit2_tests instead of build/libgit2_tests for iOS.

And we can fix it by modifying tests/libgit2/CMakeLists.txt. But it will then be killed since it is an iOS app and we are running it directly on macOS.

1 - offline (Subprocess killed)

I suggest for now we just skip the tests on iOS and add them back later.

@ethomson
Copy link
Copy Markdown
Member

ethomson commented Sep 6, 2024

I suggest for now we just skip the tests on iOS and add them back later.

👍

Thanks; I want to figure out how this integrates with #6848 since they're touching roughly the same bits of code. Will get these both merged this weekend. Thanks for this effort!

@ethomson
Merge remote-tracking branch 'origin/main' into securetransport
851628f
@ethomson
iOS Updates
41f6f72 
Some minor refactoring for iOS:

- Roll back clar changes; these should be a bit more measured, and occur
  in clar upstream.
- Move iOS to nightly builds
@ethomson
Copy link
Copy Markdown
Member

ethomson commented Sep 26, 2024

Thanks! I moved the iOS build into the nightlies, and I reverted the clar changes so that we could think a bit more how (or if) we would address iOS on clar.

@ethomson ethomson merged commit d19558a into libgit2:main Sep 26, 2024
@Kyle-Ye Kyle-Ye deleted the optimize/ios branch September 27, 2024 03:19
@ethomson ethomson added cleanup and removed feature labels Oct 19, 2024
@BrewTestBot BrewTestBot mentioned this pull request Dec 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cleanup

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add SecCopyErrorMessageString for iOS

3 participants

@Kyle-Ye @Uncommon @ethomson