Support pipenv#888
Merged
Merged
Conversation
added 30 commits
February 16, 2018 10:50
added 23 commits
February 20, 2018 21:16
Codecov Report
@@ Coverage Diff @@
## master #888 +/- ##
==========================================
+ Coverage 64.08% 64.58% +0.49%
==========================================
Files 257 259 +2
Lines 11855 11980 +125
Branches 2110 2128 +18
==========================================
+ Hits 7597 7737 +140
+ Misses 4249 4234 -15
Partials 9 9
Continue to review full report at Codecov.
|
MikhailArkhipov
commented
Feb 24, 2018
| // tslint:disable-next-line:no-empty | ||
| } catch (error) { | ||
| const appShell = this.serviceContainer.get<IApplicationShell>(IApplicationShell); | ||
| appShell.showWarningMessage(`Workspace contains pipfile but attempt to run 'pipenv --venv' failed with $${error}. Make sure pipenv is on the PATH.`); |
DonJayamanne
approved these changes
Feb 26, 2018
| // tslint:disable-next-line:no-empty | ||
| } catch (error) { | ||
| const appShell = this.serviceContainer.get<IApplicationShell>(IApplicationShell); | ||
| appShell.showWarningMessage(`Workspace contains pipfile but attempt to run 'pipenv --venv' failed with $${error}. Make sure pipenv is on the PATH.`); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #404