Mitigate packaged preindexed source open lock convoy#6172
Merged
JohnMcPMS merged 2 commits intoApr 23, 2026
Merged
Conversation
Use an optimistic packaged source open and retry under the existing mutex only if the unlocked read hits a transient race.\n\nCo-authored-by: Copilot <[email protected]>
JohnMcPMS
reviewed
Apr 23, 2026
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
JohnMcPMS
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #6167
Summary
This change narrows the lock scope for packaged preindexed source opens.
Previously, opening a packaged preindexed source always acquired the named cross-process lock before doing the read-only open work. Under concurrent
wingetusage, that serialized source reads behind unrelated activity and caused large stalls before commands likeshoworsearchcould do meaningful work.This PR changes the packaged-context open path to:
The change is limited to PreIndexedPackageSourceFactory.cpp.
Testing
Manual validation against the issue repro:
Static validation:
Microsoft Reviewers: Open in CodeFlow