Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughMemory64/Imported memory is required across the build and runtime: package bumped to 2.4.0, WASM/tooling updated for 64-bit memory, worker code switched to BigInt pointer handling, EMSDK/docker flags and CDN/submodule references updated, plus minor README and UI tweaks. Changes
Sequence Diagram(s)sequenceDiagram
participant Client as Client
participant Worker as Worker (llama-cpp.js)
participant Wasm as WASM Module
participant Memory as WASM Memory (64-bit)
Note over Worker,Wasm: BigInt pointer flow with 64-bit WASM memory (MEMORY64 + IMPORTED_MEMORY)
Client->>Worker: request (infer / embed)
Worker->>Wasm: module.init() (cwrap pointer type = 'bigint')
Worker->>Memory: wllama_malloc(size: BigInt)
Memory-->>Worker: pointer (BigInt)
Worker->>Wasm: write input at HEAPU8[ Number(pointer) ]
Worker->>Wasm: call wllama.action(pointer: BigInt, ...)
Wasm->>Memory: read/write using 64-bit addresses
Wasm-->>Worker: returns output pointer (BigInt)
Worker->>Wasm: read output via HEAPU8[ Number(outputPtr) ]
Worker-->>Client: respond with result
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
examples/main/src/components/MarkdownMessage.tsx (1)
15-15: Formatting change appears unrelated to PR objectives.This line contains only a formatting change (collapsing attributes onto one line), which doesn't relate to the mem64 feature or version bump described in the PR objectives. This might be an accidental auto-formatter change.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@examples/main/src/components/MarkdownMessage.tsx` at line 15, Revert the unrelated formatting change in the MarkdownMessage component: restore the original attribute formatting for the <code ... {...props}> element (i.e., split attributes back to their previous lines) so the diff only contains mem64/version-bump related changes; locate the <code className="bg-base-200 rounded px-1 py-[2px] text-sm" {...props}> occurrence inside the MarkdownMessage (component function) and adjust it to match the prior formatting style used in the file.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@README.md`:
- Line 14: Update the English in the README sentence that reads "Please follows
[this issue]..." by changing "Please follows" to "Please follow" so the sentence
reads "Please follow [this issue]..." (locate the sentence containing "Memory64
is now a requirement, which drops support for Safari. Please follows" and
correct the verb).
In `@src/workers-code/llama-cpp.js`:
- Line 339: The call to wllamaMalloc uses a numeric 0 for the second parameter
while the cwrap declaration expects a BigInt-sized argument; update the call
where inputPtr is assigned (const inputPtr = await
wllamaMalloc(BigInt(argEncodedMsg.byteLength), 0)) to pass a BigInt literal
(e.g., 0n or BigInt(0)) so the second argument matches the 'bigint' typing
declared for wllamaMalloc.
---
Nitpick comments:
In `@examples/main/src/components/MarkdownMessage.tsx`:
- Line 15: Revert the unrelated formatting change in the MarkdownMessage
component: restore the original attribute formatting for the <code ...
{...props}> element (i.e., split attributes back to their previous lines) so the
diff only contains mem64/version-bump related changes; locate the <code
className="bg-base-200 rounded px-1 py-[2px] text-sm" {...props}> occurrence
inside the MarkdownMessage (component function) and adjust it to match the prior
formatting style used in the file.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: c3f888dc-7e64-4834-b44a-98fd3948ded2
⛔ Files ignored due to path filters (3)
package-lock.jsonis excluded by!**/package-lock.jsonsrc/multi-thread/wllama.wasmis excluded by!**/*.wasmsrc/single-thread/wllama.wasmis excluded by!**/*.wasm
📒 Files selected for processing (12)
README.mdcpp/wllama.cppexamples/main/src/components/MarkdownMessage.tsxllama.cpppackage.jsonscripts/build_wasm.shscripts/docker-compose.ymlsrc/multi-thread/wllama.jssrc/single-thread/wllama.jssrc/wasm-from-cdn.tssrc/workers-code/generated.tssrc/workers-code/llama-cpp.js
This was referenced May 8, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepare for 2.4 release
Ref issue: #210
Summary by CodeRabbit
New Features
Documentation
Chores
Style