chore(http2): collapse duplicate request stream setup#5140
Merged
mcollina merged 1 commit intoMay 2, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5140 +/- ##
=======================================
Coverage 93.25% 93.25%
=======================================
Files 110 110
Lines 36249 36241 -8
=======================================
- Hits 33803 33797 -6
+ Misses 2446 2444 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
metcoder95
approved these changes
Apr 30, 2026
Assisted-by: openai:gpt-5.5 Signed-off-by: Kamat, Trivikram <[email protected]>
29ed787 to
68cc047
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Internal HTTP/2 client request stream setup cleanup.
Rationale
The
expectContinueand normal request paths inclient-h2duplicated stream creation and setup.Sharing that setup reduces branch/code overhead and keeps the hot path easier to tune later.
Changes
100-continueheader only whenexpectContinueis enabled.requestStreamcreation and setup path for both continue and normal requests.Features
N/A
Bug Fixes
N/A
Breaking Changes and Deprecations
N/A
Status
Assisted-by: openai:gpt-5.5