fix(test): make deduplicate body-streaming test non-flaky#5196
Merged
Conversation
Replace timing-based sleep(20) with once(res.body, 'readable') to reliably wait for the first body chunk to arrive before issuing the second request. Fixes #5182
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5196 +/- ##
==========================================
- Coverage 93.28% 93.26% -0.02%
==========================================
Files 110 110
Lines 36313 36313
==========================================
- Hits 33873 33866 -7
- Misses 2440 2447 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
trivikr
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
await sleep(20)withawait once(res1.body, 'readable')in the "does not deduplicate requests that arrive after body streaming starts" test.The 20ms sleep was a race — sometimes the first body chunk hadn't arrived yet, so
#responseDataStartedwas stillfalseand the second request was deduplicated when it shouldn't have been.Waiting for the
readableevent on the body stream guarantees the first chunk has actually been received before issuing the second request.Fixes #5182