Add registry keyword argument to PrometheusMetricReader#5055
Merged
aabmass merged 13 commits intoMay 8, 2026
Conversation
MikeGoldsmith
requested changes
Apr 13, 2026
Member
MikeGoldsmith
left a comment
There was a problem hiding this comment.
Looks good, thanks @Manvi2402 - I've left some simple clean up to do before we accept.
Co-authored-by: Mike Goldsmith <[email protected]>
Contributor
Author
|
Thanks for the review @MikeGoldsmith . I've made the requested cleanup changes. Please let me know if anything else is needed. |
MikeGoldsmith
approved these changes
Apr 13, 2026
Member
MikeGoldsmith
left a comment
There was a problem hiding this comment.
Looks good - thanks @Manvi2402. Please can you resolve the changelog conflict, there was a release recently so just needs a little clean up.
Contributor
Author
|
@MikeGoldsmith Done, resolved the changelog conflict . |
…nvi2402/opentelemetry-python into fix/prometheus-registry-kwarg
aabmass
approved these changes
May 8, 2026
…xporter/prometheus/__init__.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a registry keyword argument to PrometheusMetricReader.init(), defaulting to the global REGISTRY. This allows users to pass a custom CollectorRegistry instance, which is useful for testing scenarios that require a fresh registry per test.
Note: The second part of the issue (set_meter_provider repeated calls) is not included in this PR.
Fixes #4713
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Contrib Repo Change?
Checklist: