[2.9.x] Fix ClassCastException when using @With Java annotation (backport #13282) by @mkurz#13284
Merged
Merged
Conversation
mkurz
approved these changes
May 22, 2025
ClassCastException when using @With Java annotation (backport #13282) by @mkurzClassCastException when using @With Java annotation (backport #13282) by @mkurz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See
This does not fix the problem but at least avoids the
ClassCastExceptionWhen using
@Withdirectly on an action method, there simply is no configuration.Even the "Simple Action" that is used in the docs when using
@Withmake that clear and usesVoidplayframework/core/play/src/main/java/play/mvc/Action.java
Lines 50 to 51 in cf19f57
However, what the author in #13281 tries, even fails with a
ClassCastExceptionwhen usingAction.Simplebecause alsoVoidcan not be cast to the desired type.This is an automatic backport of pull request #13282 done by Mergify.