implementing random function for strands#8730
Merged
Merged
Conversation
Collaborator
Author
|
Hi @davepagurek and @ksen0 , sorry for the delay, its open for the review, Can you please check once? |
davepagurek
reviewed
Apr 27, 2026
Contributor
davepagurek
left a comment
There was a problem hiding this comment.
Thanks for taking this on, the structure is looking good! I left one thing about possibly making the call index a runtime thing instead of compile time to better support for loops, and maybe we could add a test case for vertex + fragment shaders too?
| if (shaderType === 'vertex') { | ||
| if (!main.match(/\@builtin\s*\(\s*instance_index\s*\)/)) { | ||
| main = main.replace(/\)\s*(->|\{)/, ', @builtin(instance_index) instanceID: u32) $1'); | ||
| const ensuredInstance = ensureBuiltinParam(main, 'instance_index', 'instanceID', 'u32'); |
Contributor
There was a problem hiding this comment.
nice work generalizing this!
davepagurek
approved these changes
May 3, 2026
Contributor
davepagurek
left a comment
There was a problem hiding this comment.
Nice, this looks good! Great work @perminder-17!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.