[elpi] matching parens of same color + nested quotations#2651
Merged
Conversation
Collaborator
|
Good catch. Would you mind adding an example for this? Previously apparently the first parentheses was matched as whitespace. |
Contributor
|
Please run CI |
Anteru
requested changes
Mar 27, 2024
| (r"\s", Text.Whitespace), | ||
| (r"(lp:)({})".format("{{"), bygroups(Number, Punctuation), 'elpi-quote-exit'), | ||
| (r"(lp:)((?=[A-Z_]){})".format(constant_re), bygroups(Number, Name.Variable)), | ||
| (r".", Text), |
Collaborator
There was a problem hiding this comment.
Also .+, otherwise you get one match per character (see your output - you want multiple consecutive characters to match?
Contributor
Author
There was a problem hiding this comment.
this is a good idea! Nonetheless, .+ is overly aggressive, as I don't intend to capture all characters up to the next \n.
I can opt for a more nuanced approach, drawing inspiration from .+ but employing negative lookahead.
Contributor
|
Please run ci |
gares
approved these changes
Jul 10, 2024
Contributor
|
Looks good to me |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original (matching parens of different color)
Fixed
Original (nested quotations):
Fixed:
CC @gares