You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
_decimal deliberately calls PyType_Ready() at the top of PyInit__decimal(), so I don't see the need for the new function here. I'm not going to restructure the whole init.
So please just remove these changes, no need for a separate PR.
@vstinner@skrah
Thanks for the review :)
I 've reverted decimal. Please take a look.
corona10
changed the title
bpo-40024: Update _elementtree/_decimal to use PyModule_AddType
bpo-40024: Update _elementtree to use PyModule_AddType
Mar 29, 2020
Traceback (most recent call last):
File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto-pgo/build/Lib/test/test_concurrent_futures.py", line 1119, in test_crash
executor.shutdown(wait=True)
File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto-pgo/build/Lib/concurrent/futures/process.py", line 712, in shutdownself._executor_manager_thread_wakeup.wakeup()
File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto-pgo/build/Lib/concurrent/futures/process.py", line 80, in wakeupself._writer.send_bytes(b"")
File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto-pgo/build/Lib/multiprocessing/connection.py", line 205, in send_bytesself._send_bytes(m[offset:offset + size])
File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto-pgo/build/Lib/multiprocessing/connection.py", line 416, in _send_bytesself._send(header + buf)
File "/home/dje/cpython-buildarea/3.x.edelsohn-rhel8-z.lto-pgo/build/Lib/multiprocessing/connection.py", line 373, in _send
n = write(self._handle, buf)
OSError: [Errno 9] Bad file descriptor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue40024