Skip to content

bpo-40600: Disallow loading extension modules load more than once in per interpreter.#23683

Closed
shihai1991 wants to merge 1 commit into
python:masterfrom
shihai1991:bpo_40600
Closed

bpo-40600: Disallow loading extension modules load more than once in per interpreter.#23683
shihai1991 wants to merge 1 commit into
python:masterfrom
shihai1991:bpo_40600

Conversation

@shihai1991
Copy link
Copy Markdown
Member

@shihai1991 shihai1991 commented Dec 7, 2020 •
edited by bedevere-bot
Loading

  • Add _PyState_AddSingleModule() and _PyState_FindSingleModule() in pystate.c.
  • Add Py_MODFLAGS_SINGLE of module flags

Co-authored-by: Dong-hee Na [email protected]

https://bugs.python.org/issue40600

@shihai1991
Disallow loading extension modules load more than once in per interpr…
b3c9b35 
…eter.

* Add _PyState_AddSingleModule() and _PyState_FindSingleModule() in pystate.c.
* Add `Py_MODFLAGS_SINGLE` of module flags
@shihai1991
Copy link
Copy Markdown
Member Author

shihai1991 commented Dec 7, 2020

@corona10 Hi, Dong-hee Na. Do you mind I copied your testcase test_multiple_loading_on_subinterpreter in here?(ps: I added you as a co-author in here ;))

@brettcannon brettcannon requested review from vstinner and removed request for brettcannon December 7, 2020 21:54
@corona10
Copy link
Copy Markdown
Member

corona10 commented Dec 8, 2020

@shihai1991 Thanks!

vstinner
vstinner requested changes Dec 8, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure that we really need this feature: see https://bugs.python.org/issue40600 discussion.

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Dec 8, 2020

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@encukou
Copy link
Copy Markdown
Member

encukou commented Dec 15, 2020 •
edited by bedevere-bot
Loading

This is solved in a different way in bpo-42639.
Thank you for working on this issue, even though this PR didn't make it in!

@encukou encukou closed this Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner requested changes

@encukou encukou Awaiting requested review from encukou

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently

@ncoghlan ncoghlan Awaiting requested review from ncoghlan

@warsaw warsaw Awaiting requested review from warsaw

Assignees

No one assigned

Labels

awaiting changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@shihai1991 @corona10 @bedevere-bot @encukou @vstinner @the-knights-who-say-ni