[3.8] bpo-47138: Fix documentation build by pinning Jinja version to 3.0.3#32109
Merged
Conversation
Member
|
See my comments on the bug issue. |
hugovk
requested changes
Mar 28, 2022
Member
hugovk
left a comment
There was a problem hiding this comment.
Shall we also use this new bpo number? https://bugs.python.org/issue47138
Contributor
Author
|
I've minimalized the change, there is only a pin for Jinja. Updated the commit message. |
hugovk
approved these changes
Mar 28, 2022
Member
hugovk
left a comment
There was a problem hiding this comment.
Thanks!
Docs build now passing:
https://github.com/python/cpython/actions/runs/2051902974
And the docs build artifact looks good:
https://github.com/python/cpython/suites/5826772454/artifacts/195475317
This was referenced Mar 28, 2022
ned-deily
approved these changes
Mar 28, 2022
Member
|
Looks good, thanks! Assigning to @ambv to approve and merge for 3.8. |
raghavthind2005
approved these changes
Mar 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently released version of Jinja (3.1.0) changed API used by Sphinx.
https://bugs.python.org/issue47138
issue45618