bpo-20180: Simplify char_converter in Argument Clinic.#9828
Conversation
|
@serhiy-storchaka, I wrote the existing escaping mechanism based on my reading of the C standard, since I recall also being surprised by I definitely defer to your judgement on this. I'm not a C expert and so I was extra-careful when I wrote this code, perhaps overly so. |
|
I think that the repr of
|
Assuming Same goes for |
vstinner
left a comment
There was a problem hiding this comment.
It seems like you fixed a bug, so I would expect a new test to check for non-regression. Is it something doable? Sorry, I didn't look at test_clinic.py.
The
char_converterconverter can be simpler.The current code doesn't work correctly with characters from 0x0e to 0x1f and >= 0x7f. And it escapes
?for unknown reasons.https://bugs.python.org/issue20180