Added type hints to additional tests#7816
Merged
Merged
Conversation
hugovk
approved these changes
Feb 20, 2024
hugovk
reviewed
Feb 20, 2024
| | tuple[float, ...] | ||
| ) | ||
| ) -> tuple[tuple[float, ...], ...]: | ||
| def truncate_tuple(tuple_or_float: tuple[Any, ...]) -> tuple[Any, ...]: |
Member
There was a problem hiding this comment.
This parameter is called tuple_or_float but typed only as a tuple.
Do we ever call it as a float? If not, shall we rename it?
Member
Author
There was a problem hiding this comment.
I've pushed a commit to rename it to tuple_value.
hugovk
approved these changes
Feb 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.