Add SFTP encoding support#9451
Conversation
|
Updated the branch with the same golang.org/x dependency bump now on upstream master to address the govulncheck failure from the previous lint job. Local verification on the new head (1f2c39f):
The new upstream Actions run is currently |
ncw
left a comment
There was a problem hiding this comment.
This looking great - thank you :-)
I found one minor nit which the lint checks will surface when I run them.
Otherwise perfect!
c8981d1 to
311e672
Compare
|
Follow-up pushed in GitHub Actions for the new head are back to |
311e672 to
ce2a9c5
Compare
|
Checked the current head Local verification:
|
|
Github actions is down at the moment :-) I think this is ready to merge but I want to see it run through the actions first! |
Signed-off-by: Puneet Dixit <[email protected]>
Signed-off-by: Puneet Dixit <[email protected]>
ce2a9c5 to
73af29d
Compare
ncw
left a comment
There was a problem hiding this comment.
Thank you - this is great :-)
I tested this locally since Github actions is not picking up this PR.
Will merge now.
Summary
encodingoption for SFTPFixes #8574
Verification
GOMODCACHE=/tmp/rclone-8574-gomodcache GOCACHE=/tmp/rclone-8574-gocache go test ./backend/sftp -run '^(TestShellEscapeUnix|TestShellEscapeCmd|TestShellEscapePowerShell|TestRemotePathEncodesRemoteNames|TestRemoteShellPathEncodesRemoteNames|TestRemoteShellPathEncodesPathOverrideNames|TestParseHash|TestParseUsage|TestSSHExternalWaitMultipleCalls|TestSSHExternalCloseMultipleCalls|TestStringLock)$' -count=1\n-GOMODCACHE=/tmp/rclone-8574-gomodcache GOCACHE=/tmp/rclone-8574-gocache go test ./lib/encoder -count=1\n-GOMODCACHE=/tmp/rclone-8574-gomodcache GOCACHE=/tmp/rclone-8574-gocache make backenddocs\n-GOMODCACHE=/tmp/rclone-8574-gomodcache GOCACHE=/tmp/rclone-8574-gocache make compiletest\n-git diff --check\n-test -z "$(gofmt -l backend/sftp/sftp.go backend/sftp/sftp_internal_test.go)"\n\nNote:go test ./backend/sftp -count=1reaches the integration tests in this environment and fails becausefstest/testserver/init.d/run.bashrequires aflockbinary that is not available locally. The SFTP package unit subset above passed.