feat: optimize RestMethodInfo, reduce dictionary allocations and li…#1742
Merged
Merged
Conversation
09eb140 to
1b8282d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1742 +/- ##
==========================================
- Coverage 87.73% 83.91% -3.82%
==========================================
Files 33 36 +3
Lines 2348 2444 +96
Branches 294 340 +46
==========================================
- Hits 2060 2051 -9
- Misses 208 309 +101
- Partials 80 84 +4 ☔ View full report in Codecov by Sentry. |
ChrisPulman
approved these changes
Jun 29, 2024
Member
|
Now I see what happened before, as you click merge the browser then scrolls after a short delay making you think your clicking confirm, but the scrolling pushes the Close button into the same place 😖 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ParameterInfoMaptoParameterInfoArray.Headers,HeaderParameterMap,PropertyParameterMap,QueryParameterMap,AttachmentNameMapto only allocate a dictionary when needed.Emptydictionary is a little risky but I dont see why we'd ever want to mutate the collection.EmptyDictionary<TKey, TValue>.get()to create static empty dictionaries. I would prefer to useImmutableDictionary.Emptyand changeDictionarytoIReadOnlyDictionarybut they aren't available in . Net Framework.bodyParamEnumerableandauthorizeParamsEnumerablenow use a tuple instead of an anonymous class.HeaderCollectionParameterIndexinstead of the hashsetHeaderCollectionParameterMapWe could probably get away with using arrays instead of
Dictionary<int, TSomething>they would use less memory in most cases and would have faster lookups for smaller numbers.Saves 4Kb of memory, I might be able to do more after profiling.
Original
Changes