Add settings for import handling and long string reflow#267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds first-class sbt settings for a few
google-java-formatCLI options that are not part ofJavaFormatterOptions, but are still supported by the formatter when invoked through the CLI.Added settings:
javafmtSortImportsjavafmtRemoveUnusedImportsjavafmtReflowLongStringsThese are wired through to the forked
google-java-formatprocess as:--skip-sorting-imports--skip-removing-unused-imports--skip-reflowing-long-stringsDocumentation:
Add scripted coverage for each new setting, tested locally (also made them fail).
This keeps
javafmtOptionsfor the upstreamJavaFormatterOptionssubset, while exposing the additional CLI-only options as dedicated sbt settings.