You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am totally OK using this pull request instead of mine (#68).
However I think it is still a good idea to disable javafmtOnCompile by default. First to keep it aligned with scalafmt, which also disables format on compile by default, second I think it may be too intrusive: E.g. if you add the plugin to a project and have uncommitted changes in java files, the formatter kicks in and re-formats everything, and suddenly you end up not knowing what were the changes you did and what are the changes javafmt did. That happend to me once.
BTW: I did not review the pull request.
Apologies! I did miss #68 There were a lot of open PR and I didn't see this one in the middle of them.
Yeah I also agree that formatting on compile should be disabled by default; I only kept it as is right now to make the transition smooth for the javafmtOnCompile setting. My plan was: release a new version with this now and in the next version break the current behaviour. We can however do it in one blow ¯_(ツ)_/¯ . lmwt.
ennru
changed the title
Add javafmOnCompile setting
Add javafmtOnCompile setting
Mar 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users could disable
AutomateJavaFormatterPluginhowever i think it's not very intuitive; lmtk what do you think about adding this setting.With this setting we have some parity with
scalafmtOnCompile