Add pattern matching support via deconstruct_keys for Result and Failure#329
Merged
Conversation
- Introduced `deconstruct_keys` to `Servactory::Result` and `Servactory::Exceptions::Failure` for Ruby 3.2+ pattern matching support. - Created two example services (`Example1` and `Example2`) under `Usual::DeconstructKeys` to demonstrate functionality. - Added corresponding RSpec tests to validate and illustrate `deconstruct_keys` behavior, including key filtering, case/in matching, and nested error handling. - Updated comments and RBS definitions to document `deconstruct_keys`.
- Added a new RSpec test to `Example2` service under `Usual::DeconstructKeys` to validate behavior when filtering specific keys (e.g., `[:type]`) via `Failure#deconstruct_keys`. - Ensures accurate handling of key filtering in failure results, improving test coverage for pattern matching scenarios.
- Simplified the doc comment in `Servactory::Result` to reflect general pattern matching support, removing the specific mention of Ruby 3.2+. - Maintains clarity while ensuring the comment is less version-dependent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.