Add async thread-safety tests and deprecate legacy Extensions module#333
Merged
Conversation
- Added deprecation warnings for the `Extensions` module and `with_extensions` method. - Provided guidance to migrate to the Stroma-based `extensions do...end` DSL. - Highlighted limitations of the deprecated approach, such as lack of thread safety and global shared state mutation. - Updated comments to clarify the benefits of the new mechanism, including per-class isolation and thread-safe hook management.
- Introduced new examples (`Example2`, `Example3`, `Example4`, `Example5`) under `Usual::Async`. - Each example demonstrates unique async operations like greetings, error handling, computation, and stress tests. - Added RSpec tests for all examples, validating inputs, outputs, and async behavior. - Included stress tests and validation scenarios to ensure thread safety and correctness.
- Add explicit `required: false` to `should_fail` input with default value - Add `.default(false)` assertion in spec input validations
- Adjusted indentation of deprecation comments for improved readability and consistency. - Ensured alignment in notes about transitioning to the Stroma-based `extensions do...end` DSL. - No functional changes introduced; purely a documentation update for clarity.
- Replaced explicit hash key definition with shorthand syntax (`id:`) for improved readability. - No functional changes; purely a syntax refinement in the test inputs setup.
- Updated method calls by adding parentheses to `sleep` across all examples. - Changes applied to `Example1`, `Example2`, `Example3`, and `Example4`. - No functional impact; improves code readability and adheres to coding style standards.
…feature/SRV-429/async
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.