Improve attribute lookup and indexing across all Set-backed collections#337
Merged
Conversation
- Added `attributes_index` to optimize attribute lookups by name. - Replaced `find`-based attribute lookup with hash-based retrieval for improved performance. - Updated delegation to include `each_with_object`. - Enhanced readability and consistency by renaming variables from `item` to `attribute`. - Updated RBS signatures to reflect changes in indexing and naming.
- Added detailed inline documentation for `Collection` subclasses to improve clarity on purpose, usage, and performance characteristics. - Introduced hash-based lookups for optimized attribute and helper indexing in `OptionHelpersCollection` and `Attributes::Collection`. - Updated delegation methods to include more enumeration methods like `each_with_object` and `flat_map`. - Enhanced constructor and duplication handling to support memoization resets. - Revised RBS signatures to align with new indexing and caching structures.
- Reorganized `def_delegators` formatting for improved readability. - Removed redundant delegations (`find` in `Options::Collection`) to simplify code. - Aligned delegator styles across `OptionHelpersCollection`, `Attributes::Collection`, and `Options::Collection`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.