Support undefined number of data points in the mesh.#2373
Merged
Conversation
stephanwlee
requested changes
Jun 21, 2019
Contributor
stephanwlee
left a comment
There was a problem hiding this comment.
About the JavaScript reviews: I can send you a pull request if you think that helps.
Contributor
|
+reviewer: wchargin for Python readability. |
wchargin
reviewed
Jun 21, 2019
Improving readability and perf
wchargin
reviewed
Jun 24, 2019
wchargin
suggested changes
Jun 24, 2019
Contributor
wchargin
left a comment
There was a problem hiding this comment.
Requesting changes to maintain data compatibility.
wchargin
reviewed
Jun 25, 2019
wchargin
reviewed
Jun 25, 2019
Contributor
Author
|
FYI, updated SHA for TF Graphics-hosted files, so you can test the whole thing if needed. Please let me know if there is anything else is needed to merge the change. |
stephanwlee
reviewed
Jun 27, 2019
stephanwlee
reviewed
Jun 27, 2019
Contributor
stephanwlee
left a comment
There was a problem hiding this comment.
FE and most changes LGTM. I will let William finish review the Python part.
wchargin
reviewed
Jul 1, 2019
wchargin
approved these changes
Jul 11, 2019
stephanwlee
approved these changes
Jul 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support of undefined (None) number of vertices/faces/colors in the mesh.
How to test:
Run demo app and then launch tensorboard - observe mesh being rendered.
Also this PR changes the way we load data - from now on, every step is considered as unique data point and should be requested separately from the server (similar to image plugin). Please note that each mesh/step will produce 1 to 3 requests based on what data was passed into the summary (i.e. if there are no colors specified, then it will request only vertices and faces).
This PR depends on some TF-Graphics changes (I'll update it with new SHA once changes merged).