manager: launch TENSORBOARD_BINARY if available#2386
Merged
Conversation
Summary: This enables specifying the TensorBoard binary with an environment variable. Callers previously needed to set up a `PATH` with a custom binary; this is simpler and less intrusive. Test Plan: (to be written; pushing now to start Travis) wchargin-branch: tensorboard-binary
wchargin-source: 9d84973a67cbdb91f1505d5cf29b0bf1443892f8 wchargin-branch: tensorboard-binary
nfelt
approved these changes
Jun 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This enables specifying the TensorBoard binary with an environment
variable. Callers previously needed to set up a
PATHwith a custombinary; this is simpler and less intrusive.
(Googlers, see comments on http://cl/236333099 for context.)
Test Plan:
The newly added test fails before this change and passes after it.
wchargin-branch: tensorboard-binary